move warning to package provider layer

Author: edyoung

Tests/Pester.PSRepository.Tests.ps1

@@ -247,10 +247,23 @@ Describe 'Managing repositories' -Tag BVT {
     }
 
     It "Should let you register an unreachable repository but produce a warning" {
-        Register-PSRepository -Name NewRepo -SourceLocation "https://nowhere.com/api/v2" -WarningVariable warning -WarningAction SilentlyContinue
+        # microsoft.com exists but doesn't host a nuget repo
+        Register-PSRepository -Name NewRepo -SourceLocation "https://microsoft.com/api/v2" -WarningVariable warning -WarningAction SilentlyContinue
         $warning | Should BeLike "*Unable to reach URL*"
     }
 
+    It "Should let you change a repo to an unreachable location but produce a warning" {
+        Register-PSRepository -Name NewRepo -SourceLocation "https://www.microsoft.com/api/v2"-WarningAction SilentlyContinue
+        Set-PSRepository -Name NewRepo -SourceLocation "https://docs.microsoft.com/api/v2" -WarningVariable warning -WarningAction SilentlyContinue
+        $warning | Should BeLike "*Unable to reach URL 'https://docs*"
+    }
+
+    It "Should let you add a package source but produce a warning" {
+        Register-PackageSource NewRepo -Location https://microsoft.com/api/v2 -ProviderName powershellget -WarningVariable warning -WarningAction SilentlyContinue
+        $warning | Should BeLike "*Unable to reach URL*"
+    }
+
+
     It "Should not let you register 2 repositories which differ only by /" {
         Register-PSRepository -Name NewRepo -SourceLocation "https://nowhere.com/api/v2" -WarningAction SilentlyContinue
         { Register-PSRepository -Name NewRepoSlash -SourceLocation "https://nowhere.com/api/v2/" -WarningAction SilentlyContinue } | Should -Throw

src/PowerShellGet/PSGet.Resource.psd1

@@ -99,7 +99,7 @@ ConvertFrom-StringData @'
         FailedToPublish=Failed to publish module '{0}': '{1}'.
         PublishedSuccessfully=Successfully published module '{0}' to the module publish location '{1}'. Please allow few minutes for '{2}' to show up in the search results.
         InvalidWebUri=The specified Uri '{0}' for parameter '{1}' is an invalid Web Uri. Please ensure that it meets the Web Uri requirements.
-        WarnUnableToReachWebUri=Unable to reach URL at '{0}' for parameter '{1}'. Please check that the URL is correct.
+        WarnUnableToReachWebUri=Unable to reach URL '{0}'. Please check that the URL is correct.
         RepositoryAlreadyRegistered=The repository could not be registered because there exists a registered repository with Name '{0}' and SourceLocation '{1}'. To register another repository with Name '{2}', please unregister the existing repository using the Unregister-PSRepository cmdlet.
         RepositoryToBeUnregisteredNotFound=The repository '{0}' was not removed because no repository was found with that name. Please run Get-PSRepository and ensure that a repository of that name is present.
         RepositoryCannotBeUnregistered=The specified repository '{0}' cannot be unregistered.

src/PowerShellGet/private/functions/Resolve-Location.ps1

@@ -73,8 +73,10 @@ function Resolve-Location
         else
         {
             # We couldn't reach the repo. Register it anyway but warn the user if we're able
+            # We'd like to include the parameter name here, but Register-PSRepository calls Add-PackageSource, 
+            # and both use different param names, so the parameter name becomes confusing
             if($CallerPSCmdlet -and -not $SkipLocationWarning) {
-                $message = $LocalizedData.WarnUnableToReachWebUri -f ($Location, $LocationParameterName)
+                $message = $LocalizedData.WarnUnableToReachWebUri -f ($Location)
                 Write-Warning $message
             }
             return $Location

src/PowerShellGet/public/providerfunctions/Add-PackageSource.ps1

@@ -266,8 +266,7 @@ function Add-PackageSource
                                      -Credential $Credential `
                                      -Proxy $Proxy `
                                      -ProxyCredential $ProxyCredential `
-                                     -CallerPSCmdlet $PSCmdlet `
-                                     -SkipLocationWarning # otherwise we get duplicate warnings for unreachable repos
+                                     -CallerPSCmdlet $PSCmdlet
     }
 
     if(-not (Microsoft.PowerShell.Management\Test-Path -Path $Location) -and

src/PowerShellGet/public/psgetfunctions/Register-PSRepository.ps1

@@ -149,8 +149,9 @@ function Register-PSRepository
                                                -Credential $Credential `
                                                -Proxy $Proxy `
                                                -ProxyCredential $ProxyCredential `
-                                               -CallerPSCmdlet $PSCmdlet
-                                               
+                                               -CallerPSCmdlet $PSCmdlet `
+                                               -SkipLocationWarning
+
             $providerName = $null
 
             if($PackageManagementProvider)