Fix JSON-LD translation and related issues #846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 27, 2019 10:34
…nslation of project, fixes url encoding of dataset names
rokroskar
previously approved these changes
Nov 29, 2019
rokroskar
approved these changes
Nov 29, 2019
jsam
approved these changes
Nov 29, 2019
Panaetius
added a commit
that referenced
this pull request
Dec 3, 2019
* Add default value converter and remove dataset property from DatasetFile * Removes type from Person context, fixes missing context in jsonld translation of project, fixes url encoding of dataset names
jsam
added a commit
that referenced
this pull request
Dec 17, 2019
* SHACL Validation (#767) * Adds SHACL validation to renku doctor * Adds renku log tests * Adds --strict option to renku log for shape validation * Fix JSON-LD translation and related issues (#846) * Add default value converter and remove dataset property from DatasetFile * Removes type from Person context, fixes missing context in jsonld translation of project, fixes url encoding of dataset names * feat: added renku service with cache and datasets * fix: addressed review points * chore: added travis encrypted oauth token * fix: cleanup of user vs user_id * chore: method naming convention update * feat: set custom commit message * chore: remove defensive scoping of git options * chore: added IndexError exception sentinel * chore: added test for renku clone with custom config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #844
Removes
DatasetFile.dataset.Adds default converter for jsonld types so jsonld is always deserialized.
Propagates jsonld context so jsonld translation can work correctly
Fixes migrations
Fixes project id's for old projects
Removes type annotation from Person that was in the wrong place