Commit 883713a
authored
fix(transform): preserve export keywords on nested namespaces (#360)
Fixes #359
Removes two problematic code sections from PR #352:
1. Lines 26-28: Unnecessary duplicateExports() call that caused
superfluous export name duplication in namespace bodies
2. Lines 596-605: Incorrect removal of export keywords from nested
namespaces, which changed their accessibility from public to private
The plugin should bundle declarations, not transform their semantics.
Nested namespaces with export keywords must remain exported to:
- Maintain public API surface for downstream consumers
- Preserve correct scoping in API documentation
- Keep original type semantics intact1 parent 963a4fc commit 883713a
File tree
4 files changed
+4
-16
lines changed- src/transform
- tests/testcases
- namespace-nested-export
- namespace-nested-shadowing
- namespace-reexport-interface
4 files changed
+4
-16
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | 26 | | |
31 | 27 | | |
32 | 28 | | |
| |||
593 | 589 | | |
594 | 590 | | |
595 | 591 | | |
596 | | - | |
597 | | - | |
598 | | - | |
599 | | - | |
600 | | - | |
601 | | - | |
602 | | - | |
603 | | - | |
604 | | - | |
605 | 592 | | |
| 593 | + | |
606 | 594 | | |
607 | 595 | | |
608 | 596 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
0 commit comments