Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check before deploying contract containing non-payable constructor configured with non-zero value #151

Open
filippsen opened this issue Nov 15, 2019 · 0 comments
Labels
feature-request New feature or request

Comments

@filippsen
Copy link
Contributor

Summary

Request #146 adds a new Value configuration to enable sending funds as part of contract deployment. There is nothing preventing deployment attempts when the Value is set and the constructor is not payable.
Deploying a contract non-payable constructor leads to:

Transaction mined, verifying code...
Contract code could not be verified on chain. The contract might not have been deployed.
This is possibly a mismatch in the number/type of arguments given to the constructor or could
also be a temporary issue in reading back the contract code from the chain.

It would be more correct to verify the Value configuration matches a (expected) payable constructor before proceeding with the Deploy action.

@filippsen filippsen added the feature-request New feature or request label Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant