Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't compare TaxJar-provided transaction floats with BigDecimal order amounts #167

Open
benjaminwil opened this issue Feb 23, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@benjaminwil
Copy link
Member

In our extension's reporting subscribers, we use an #amount_changed? method to check whether we need to re-report a transaction or not. When we get a transaction from TaxJar, they give us the amounts as floats. But Solidus does not use floats internally. If we can safely convert the TaxJar amounts to BigDecimal numbers, that would be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant