-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CloudWatch metrics in sumologic polling source #24
Conversation
@vsinghal13 This needs to be reviewed by a CloudWatch source SME, Maisie or Yuting. |
Unable to tag anyone as reviewers. |
"bucket_name": { | ||
Type: schema.TypeString, | ||
Required: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there some kind of validation we would lose in Terraform after making bucket_name
and path_expression
optional because now we have two path types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not that I know of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@vsinghal13 Have you manually tested everything? |
Yes, and @sajain-sumologic will be verifying the same next week. |
Sample TF File: