Improve typing #61
Open
Improve typing #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remytuyeras
requested changes
Nov 7, 2025
Collaborator
remytuyeras
left a comment
remytuyeras
left a comment
There was a problem hiding this comment.
Yes, this could be useful. Please make the PR to dev instead of main
remytuyeras
reviewed
Nov 7, 2025
Collaborator
remytuyeras
left a comment
remytuyeras
left a comment
There was a problem hiding this comment.
Since Summoner clients can connect to different servers, this typing is not a requirement. But the type could be useful in payload.py where we define recover_with_types()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has tripped myself and AI up multiple times -- the server sends a wrapped payload with the remote IP, which is useful but could easily lose people if not made perfectly clear. Let's make this clear and explicit.