Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] rimraf #60

Open
wojtekmaj opened this issue Feb 14, 2024 · 4 comments
Open

[Feature Request] rimraf #60

wojtekmaj opened this issue Feb 14, 2024 · 4 comments

Comments

@wojtekmaj
Copy link

In Node.js v14.14.0, fs.rm and fs.rmSync was added. It's a built-in module that removes files and directories. The recursive option is used to remove directories and their contents.

rimraf is still WIDELY used, for no apparent reason.

Each copy takes a whopping 3.38 MB.

@SukkaW
Copy link
Owner

SukkaW commented Feb 14, 2024

rimraf itself is only 271 KiB. The main culprit is the glob package (which is minipass-based).

@wojtekmaj
Copy link
Author

In my opinion, it doesn't matter which package is at fault. At the end of the day, all that matters is that installing rimraf adds 4 MB to your node_modules, and it does have a native replacement.

@mary-ext
Copy link

mary-ext commented Jun 23, 2024

Does Nolyfill do a compatibility check? With Node.js supporting fs.glob and fs.globSync now it might be worth doing this.

Could also look into tackling #59 for when ESM-CJS sync interop becomes stable

@alex-kinokon
Copy link

For the record, they will not be dropping glob any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants