Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout.session.completed If payment_status is no_payment_required , then don't attempt currency (or other) invalid property accesses #1287

Open
chrisjsimpson opened this issue Feb 7, 2024 · 0 comments

Comments

@chrisjsimpson
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Stripe event checkout.session.completed may not always have a currency, for example when payment_status is no_payment_required.

no_payment_required Docs:

The payment is delayed to a future date, or the Checkout Session is in setup mode and doesn’t require a payment at this time.

subscribie/blueprints/checkout/__init__.py", line 857, in stripe_webhook                                                
    currency = session["currency"].upper()                                                                                                                                                    
               ^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                                      
AttributeError: 'NoneType' object has no attribute 'upper'  

Describe the solution you'd like

If payment_status is no_payment_required , then don't attempt currency (or other) invalid property accesses.

Describe alternatives you've considered

Additional context

currency = session["currency"].upper()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant