Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Now you can stop custom prefabs from getting cached #545

Merged
merged 5 commits into from
May 6, 2024
Merged

Now you can stop custom prefabs from getting cached #545

merged 5 commits into from
May 6, 2024

Conversation

Metious
Copy link
Member

@Metious Metious commented Apr 25, 2024 •
edited
Loading

Changes made in this pull request

  • Previously we had methods to remove a prefab from the cache, but users didn't have a place to call it, so it was useless. This PR allows users to remove prefabs at real-time (regardless of being in patch time, or in a world).
  • Added a new extension method for CustomPrefab to remove a custom prefab from the cache.
  • Fixed a bug where if a custom prefab's game object returns null, the game freezes

NOT TESTED

@Metious Metious marked this pull request as ready for review April 30, 2024 12:41
@Metious
Copy link
Member Author

Metious commented Apr 30, 2024

Tested this PR on stable branch of SN1 (v71288) and works.

LeeTwentyThree
LeeTwentyThree approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@LeeTwentyThree LeeTwentyThree left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not notice any issues while testing

@Metious Metious merged commit 1711ac2 into SubnauticaModding:master May 6, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LeeTwentyThree LeeTwentyThree LeeTwentyThree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Metious @LeeTwentyThree