Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view_syntax issue #142

Closed
eblot opened this issue May 15, 2020 · 5 comments · Fixed by #143
Closed

view_syntax issue #142

eblot opened this issue May 15, 2020 · 5 comments · Fixed by #143

Comments

@eblot
Copy link

eblot commented May 15, 2020

I've been unable to use the trailing spaces highlighting for a while, despite the Delete Trailing space menu always work.

I noticed from the console the following error in trailing_spaces.py@185:

NameError: global name 'view_syntax' is not defined

and indeed, view_syntax does not seem defined

is view_syntax could be something like

view_syntax = view_settings.get('syntax')

?

@rchl
Copy link
Member

rchl commented May 15, 2020

Wow, indeed.
I even get linter shouting at me (I guess I didn't have it before).

@rchl
Copy link
Member

rchl commented May 15, 2020

BTW. You are getting this error because you have customized syntax_ignore setting. That one is deprecated (but will still work) by new, preferred scope_ignore setting.

@rchl
Copy link
Member

rchl commented May 15, 2020

Fix released in v1.3.3.

@eblot
Copy link
Author

eblot commented May 16, 2020

BTW. You are getting this error because you have customized syntax_ignore setting. That one is deprecated (but will still work) by new, preferred scope_ignore setting.

I think it comes from quite an old setting. Before digging into the code, I uninstalled/reinstalled TrailingSpaces, but the old settings have been preserved, and I did not know which one were up to date. I'll update them, thanks for the hint.

@rchl
Copy link
Member

rchl commented May 16, 2020

Open TrailingSpaces settings from the command palette. Your customized settings should be on the right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants