Stop automatic syntax tests missing gaps (#398)#404
Merged
FichteFoll merged 2 commits intoSublimeText:masterfrom Feb 16, 2025
Merged
Stop automatic syntax tests missing gaps (#398)#404FichteFoll merged 2 commits intoSublimeText:masterfrom
FichteFoll merged 2 commits intoSublimeText:masterfrom
Conversation
Contributor
|
I also recommend adding "Fixes #398” to the OP body text, since GitHub recognizes certain specific patterns as formal links between an issue and a PR. Also consider changing the title to something like "Fix automatic syntax assertions filling gaps" or "Stop automatic syntax tests missing gaps". I think the way it is now it sounds backwards to me. |
michaelblyons
approved these changes
Feb 10, 2025
jrappen
approved these changes
Feb 15, 2025
FichteFoll
approved these changes
Feb 16, 2025
Member
FichteFoll
left a comment
There was a problem hiding this comment.
Thanks for taking a look at this issue and fixing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #398
Old Version (incorrectly assumes the space has numerical scopes):
New Version (correctly excludes space from numerical scopes):
Simply checks if the previous region's end matches with the new region's beginning when inserting into a ScopeTreeNode.