Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new completion features #292

Closed
FichteFoll opened this issue Apr 11, 2020 · 3 comments
Closed

Use the new completion features #292

FichteFoll opened this issue Apr 11, 2020 · 3 comments
Milestone

Comments

@FichteFoll
Copy link
Member

FichteFoll commented Apr 11, 2020

In order to support the new completion features, I'll likely make the next or the following build ST4-only. Very useful new features like #289 might get backported to an st3 branch, but I don't think there would need to be much maintenance for that branch otherwise. PD overall seems very stable with few bugs and most of the issues or PRs I get in are feature requests. I would then decide on a case-by-case basis if it's worth backporting.

For clarification, this includes sublime-completions files and plugin-provided. Especially because of the latter, I should probably do #289 first to have it backwards compatible.

@FichteFoll
Copy link
Member Author

As an update, this is almost done. What's missing are theme and command completions, which I hope to finish tomorrow and then roll out the new release.

@FichteFoll
Copy link
Member Author

FichteFoll commented Jan 2, 2021

Settings & command completions are done as well. Just theme (and scheme) left.

And a command to prevent buffer completions for keys that we provide completions for through .sublime-completions files.

@FichteFoll
Copy link
Member Author

All completions should use this the new format now, both plugins and completions files.

Unfortunatly, I wasn't able to inhibit buffer completions. You can see my attempt at 83de08a, but it doesn't work as expected. Moved that to sublimehq/sublime_text#3643.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant