Enhance quick open with better keyboard navigation and file opening behavior

Author: Maran23

addons/script-ide/plugin.gd

@@ -444,6 +444,21 @@ func navigate_on_list(event: InputEvent, list: ItemList, submit: Callable):
 	elif (event is InputEventKey && list.item_count > 0 && !list.is_anything_selected()):
 		list.select(0)
 
+func get_list_index(list: ItemList) -> int:
+	var items: PackedInt32Array = list.get_selected_items()
+
+	if (items.is_empty()):
+		return -1
+
+	return items[0]
+
+func navigate_list(list: ItemList, index: int, amount: int):
+	index = clamp(index + amount, 0, list.item_count - 1)
+
+	list.select(index)
+	list.ensure_current_is_visible()
+	list.accept_event()
+
 func get_center_editor_rect() -> Rect2i:
 	var script_editor: ScriptEditor = EditorInterface.get_script_editor()
 
@@ -524,21 +539,6 @@ func open_scripts_popup():
 
 	script_filter_txt.grab_focus()
 
-func get_list_index(list: ItemList) -> int:
-	var items: PackedInt32Array = list.get_selected_items()
-
-	if (items.is_empty()):
-		return -1
-
-	return items[0]
-
-func navigate_list(list: ItemList, index: int, amount: int):
-	index = clamp(index + amount, 0, list.item_count - 1)
-
-	list.select(index)
-	list.ensure_current_is_visible()
-	list.accept_event()
-
 ## Removes the script filter text and emits the signal so that the Tabs stay
 ## and we do not break anything there.
 func update_script_text_filter():

addons/script-ide/quickopen/quick_open_panel.gd

@@ -36,9 +36,19 @@ func _ready() -> void:
 	var file_system: EditorFileSystem = EditorInterface.get_resource_filesystem()
 	file_system.filesystem_changed.connect(schedule_rebuild)
 
+	filter_txt.gui_input.connect(navigate_on_list.bind(files_list, open_file))
+
 func open_file(index: int):
+	hide()
+
 	var file: String = files_list.get_item_metadata(index)
-	EditorInterface.edit_resource(load(file))
+
+	if (ResourceLoader.exists(file)):
+		var res: Resource = load(file)
+		EditorInterface.edit_resource(res)
+
+		if (res is PackedScene):
+			EditorInterface.open_scene_from_path(file)
 
 func schedule_rebuild():
 	is_rebuild_cache = true
@@ -66,6 +76,9 @@ func on_show():
 	filter_txt.select_all()
 	filter_txt.grab_focus()
 
+	if (files_list.item_count > 0):
+		files_list.select(0)
+
 func rebuild_cache():
 	scenes.clear()
 	scripts.clear()
@@ -147,6 +160,55 @@ func fill_files_list_with(files: Array[FileData]):
 			files_list.add_item(file_data.file_name, icon)
 			files_list.set_item_metadata(files_list.item_count - 1, file)
 
+func navigate_on_list(event: InputEvent, list: ItemList, submit: Callable):
+	if (event.is_action_pressed(&"ui_text_submit")):
+		var index: int = get_list_index(list)
+		if (index == -1):
+			return
+
+		submit.call(index)
+	elif (event.is_action_pressed(&"ui_down", true)):
+		var index: int = get_list_index(list)
+		if (index == list.item_count - 1):
+			return
+
+		navigate_list(list, index, 1)
+	elif (event.is_action_pressed(&"ui_up", true)):
+		var index: int = get_list_index(list)
+		if (index <= 0):
+			return
+
+		navigate_list(list, index, -1)
+	elif (event.is_action_pressed(&"ui_page_down", true)):
+		var index: int = get_list_index(list)
+		if (index == list.item_count - 1):
+			return
+
+		navigate_list(list, index, 5)
+	elif (event.is_action_pressed(&"ui_page_up", true)):
+		var index: int = get_list_index(list)
+		if (index <= 0):
+			return
+
+		navigate_list(list, index, -5)
+	elif (event is InputEventKey && list.item_count > 0 && !list.is_anything_selected()):
+		list.select(0)
+
+func get_list_index(list: ItemList) -> int:
+	var items: PackedInt32Array = list.get_selected_items()
+
+	if (items.is_empty()):
+		return -1
+
+	return items[0]
+
+func navigate_list(list: ItemList, index: int, amount: int):
+	index = clamp(index + amount, 0, list.item_count - 1)
+
+	list.select(index)
+	list.ensure_current_is_visible()
+	list.accept_event()
+
 class FileData:
 	var file: String
 	var file_name: String

addons/script-ide/quickopen/quick_open_panel.tscn

@@ -1,17 +1,35 @@
-[gd_scene load_steps=3 format=3 uid="uid://d2pttchmj3n7q"]
+[gd_scene load_steps=5 format=3 uid="uid://d2pttchmj3n7q"]
 
 [ext_resource type="Script" path="res://addons/script-ide/quickopen/quick_open_panel.gd" id="1_3tl1s"]
 
 [sub_resource type="ButtonGroup" id="ButtonGroup_8s5oe"]
 resource_local_to_scene = false
 
+[sub_resource type="Image" id="Image_k3p7r"]
+data = {
+"data": PackedByteArray(255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 225, 225, 225, 68, 224, 224, 224, 184, 224, 224, 224, 240, 224, 224, 224, 232, 224, 224, 224, 186, 227, 227, 227, 62, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 224, 224, 224, 129, 224, 224, 224, 254, 224, 224, 224, 255, 224, 224, 224, 255, 224, 224, 224, 255, 224, 224, 224, 255, 224, 224, 224, 255, 224, 224, 224, 122, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 225, 225, 225, 68, 224, 224, 224, 254, 224, 224, 224, 254, 224, 224, 224, 123, 224, 224, 224, 32, 224, 224, 224, 33, 225, 225, 225, 125, 224, 224, 224, 254, 224, 224, 224, 254, 226, 226, 226, 69, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 224, 224, 224, 184, 224, 224, 224, 255, 224, 224, 224, 123, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 225, 225, 225, 125, 224, 224, 224, 255, 225, 225, 225, 174, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 224, 224, 224, 240, 224, 224, 224, 255, 231, 231, 231, 31, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 226, 226, 226, 35, 224, 224, 224, 255, 224, 224, 224, 233, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 224, 224, 224, 232, 224, 224, 224, 255, 224, 224, 224, 32, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 228, 228, 228, 37, 224, 224, 224, 255, 224, 224, 224, 228, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 224, 224, 224, 186, 224, 224, 224, 255, 224, 224, 224, 123, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 224, 224, 224, 130, 224, 224, 224, 255, 224, 224, 224, 173, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 227, 227, 227, 62, 224, 224, 224, 255, 224, 224, 224, 254, 225, 225, 225, 126, 225, 225, 225, 34, 227, 227, 227, 36, 224, 224, 224, 131, 224, 224, 224, 255, 224, 224, 224, 255, 226, 226, 226, 77, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 224, 224, 224, 122, 224, 224, 224, 254, 224, 224, 224, 255, 224, 224, 224, 255, 224, 224, 224, 255, 224, 224, 224, 255, 224, 224, 224, 255, 224, 224, 224, 255, 224, 224, 224, 210, 231, 231, 231, 21, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 226, 226, 226, 69, 225, 225, 225, 174, 224, 224, 224, 233, 224, 224, 224, 228, 224, 224, 224, 173, 226, 226, 226, 77, 224, 224, 224, 210, 224, 224, 224, 255, 224, 224, 224, 210, 231, 231, 231, 21, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 231, 231, 231, 21, 224, 224, 224, 210, 224, 224, 224, 255, 224, 224, 224, 210, 231, 231, 231, 21, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 231, 231, 231, 21, 224, 224, 224, 210, 224, 224, 224, 255, 224, 224, 224, 210, 231, 231, 231, 21, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 231, 231, 231, 21, 224, 224, 224, 210, 224, 224, 224, 227, 225, 225, 225, 34, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 231, 231, 231, 21, 225, 225, 225, 34, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0),
+"format": "RGBA8",
+"height": 16,
+"mipmaps": false,
+"width": 16
+}
+
+[sub_resource type="ImageTexture" id="ImageTexture_bjbm4"]
+image = SubResource("Image_k3p7r")
+
 [node name="QuickOpenPanel" type="PopupPanel"]
+size = Vector2i(473, 100)
+visible = true
 script = ExtResource("1_3tl1s")
 
 [node name="PanelContainer" type="PanelContainer" parent="."]
 anchors_preset = 15
 anchor_right = 1.0
 anchor_bottom = 1.0
+offset_left = 4.0
+offset_top = 4.0
+offset_right = -4.0
+offset_bottom = -4.0
 grow_horizontal = 2
 grow_vertical = 2
 size_flags_horizontal = 3
@@ -95,8 +113,10 @@ popup/item_1/id = 1
 unique_name_in_owner = true
 layout_mode = 2
 placeholder_text = "Filter files"
+right_icon = SubResource("ImageTexture_bjbm4")
 
 [node name="FilesList" type="ItemList" parent="PanelContainer/MarginContainer/VBoxContainer"]
 unique_name_in_owner = true
 layout_mode = 2
 size_flags_vertical = 3
+allow_reselect = true