Skip to content
This repository was archived by the owner on Mar 19, 2025. It is now read-only.

Commit b62321d

Browse files
Merge pull request #949 from SubPointSolutions/dev
SPMeta2 v1.2.100, Febuary 2017
2 parents c114214 + 799a8b1 commit b62321d

File tree

54 files changed

+4125
-3225
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+4125
-3225
lines changed

SPMeta2/SPMeta2.Build/m2.buildbaseline.xml

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

SPMeta2/SPMeta2.CSOM.Standard/ModelHandlers/Taxonomy/TaxonomyTermModelHandler.cs

Lines changed: 427 additions & 350 deletions
Large diffs are not rendered by default.

SPMeta2/SPMeta2.CSOM.Standard/Properties/AssemblyInfo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,4 @@
3232
// by using the '*' as shown below:
3333
// [assembly: AssemblyVersion("1.0.*")]
3434
[assembly: AssemblyVersion("1.0.0.0")]
35-
[assembly: AssemblyFileVersion("1.2.16305.1232")]
35+
[assembly: AssemblyFileVersion("1.2.17040.0900")]

SPMeta2/SPMeta2.CSOM/ModelHandlers/Base/MasterPageModelHandlerBase.cs

Lines changed: 25 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
using SPMeta2.Definitions;
1111
using SPMeta2.Enumerations;
1212
using SPMeta2.Utils;
13+
using SPMeta2.Services;
1314

1415
namespace SPMeta2.CSOM.ModelHandlers.Base
1516
{
@@ -146,20 +147,35 @@ public override void DeployModel(object modelHost, DefinitionBase model)
146147
context.Load(newFileItem);
147148
context.ExecuteQueryWithTrace();
148149

149-
var site = folderModelHost.HostSite;
150-
var currentPageLayoutItem = FindPageLayoutItem(site, definition.FileName);
150+
//var site = folderModelHost.HostSite;
151+
//var currentPageLayoutItem = FindPageLayoutItem(site, definition.FileName);
151152

153+
//var currentPageLayoutItemContext = currentPageLayoutItem.Context;
154+
//var publishingFile = currentPageLayoutItem.File;
152155

153-
var currentPageLayoutItemContext = currentPageLayoutItem.Context;
154-
var publishingFile = currentPageLayoutItem.File;
156+
//currentPageLayoutItemContext.Load(currentPageLayoutItem);
157+
//currentPageLayoutItemContext.Load(currentPageLayoutItem, i => i.DisplayName);
158+
//currentPageLayoutItemContext.Load(publishingFile);
155159

156-
currentPageLayoutItemContext.Load(currentPageLayoutItem);
157-
currentPageLayoutItemContext.Load(currentPageLayoutItem, i => i.DisplayName);
158-
currentPageLayoutItemContext.Load(publishingFile);
160+
//currentPageLayoutItemContext.ExecuteQueryWithTrace();
159161

160-
currentPageLayoutItemContext.ExecuteQueryWithTrace();
162+
// ** SIC.. found with Problem with url in MasterPageSettings #936
163+
// https://github.com/SubPointSolutions/spmeta2/issues/936
164+
165+
// * /_catalogs/masterpage - would have 'Title' field (and correct content types)
166+
// * /my-sub-web/_catalogs/masterpage - would NOT have 'Title' fiels so that provision fails
167+
168+
// so performing Title update only for the root web
169+
if (folderModelHost.HostSite.ServerRelativeUrl == folderModelHost.HostWeb.ServerRelativeUrl)
170+
{
171+
TraceService.VerboseFormat((int)LogEventId.ModelProvisionCoreCall, "Updating master page 'Title' on the root web.", null);
172+
newFileItem[BuiltInInternalFieldNames.Title] = definition.Title;
173+
}
174+
else
175+
{
176+
TraceService.VerboseFormat((int)LogEventId.ModelProvisionCoreCall, "Skipping master page 'Title' update. Subweb is detcted.", null);
177+
}
161178

162-
newFileItem[BuiltInInternalFieldNames.Title] = definition.Title;
163179
newFileItem["MasterPageDescription"] = definition.Description;
164180
newFileItem[BuiltInInternalFieldNames.ContentTypeId] = PageContentTypeId;
165181

0 commit comments

Comments
 (0)