Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for whitelisting tags #619

Merged
merged 2 commits into from
Apr 21, 2021

Conversation

tneotia
Copy link
Collaborator

@tneotia tneotia commented Apr 12, 2021

Fixes #223

Open to discussion on this PR - I feel that this isn't a huge change and can be included as breaking in v2.0.0.

Copy link
Collaborator

@erickok erickok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this is a good change for 2.0.0. I'd just like to take the opportunity to change the terms blacklist and whitelist.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tneotia
Copy link
Collaborator Author

tneotia commented Apr 21, 2021

@erickok updated the README :)

@erickok erickok self-requested a review April 21, 2021 06:58
@erickok erickok merged commit b785705 into Sub6Resources:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hope v1.0.0 can set the whitelist of the elements
2 participants