fix FontFeature initial, ListStyleType initial#1379
Open
phamconganh wants to merge 1 commit intoSub6Resources:masterfrom
Open
fix FontFeature initial, ListStyleType initial#1379phamconganh wants to merge 1 commit intoSub6Resources:masterfrom
phamconganh wants to merge 1 commit intoSub6Resources:masterfrom
Conversation
Sub6Resources
requested changes
Mar 11, 2025
| try { | ||
| fontFeatures.add(FontFeature(exp.text, | ||
| nextExp.text == "on" || nextExp.text == "1" ? 1 : 0)); | ||
| } catch (_) {} |
Owner
There was a problem hiding this comment.
Can you describe a little bit about why we're doing this and ignoring the caught error? Is there a GitHub issue you can reference to describe what the justification for this PR is?
Author
There was a problem hiding this comment.
it was a long time ago so i don't remember clearly. there was a case that caused the init font reading to fail, i added it so it wouldn't affect the rendering
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1379 +/- ##
=======================================
Coverage 64.08% 64.08%
=======================================
Files 39 39
Lines 3032 3032
=======================================
Hits 1943 1943
Misses 1089 1089 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.