Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better onLinkTap parameter type #30

Closed
Edward608 opened this issue Oct 10, 2018 · 3 comments
Closed

Better onLinkTap parameter type #30

Edward608 opened this issue Oct 10, 2018 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@Edward608
Copy link
Contributor

Currently the type of onLinkTap is Function, which does not provide any indication of any incoming function argument, and also the type of argument.

The type should change to something like (String) -> void or make a typedef for this.

A pull request will be submitted once this issue is approved.

@Sub6Resources
Copy link
Owner

Yeah, that makes sense. If you are willing to open a pull request that would be great. If you aren't able to do it, though, I can do it.

@Sub6Resources Sub6Resources added this to the 0.9.0 milestone Oct 19, 2018
@Sub6Resources Sub6Resources added the enhancement New feature or request label Oct 19, 2018
@Edward608
Copy link
Contributor Author

Pull request #31 has been added. Please take a look when you have time.

@Sub6Resources
Copy link
Owner

Merged in version 0.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants