Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

href inside paragraph does not work on web #295

Closed
dsm5000 opened this issue May 18, 2020 · 5 comments
Closed

href inside paragraph does not work on web #295

dsm5000 opened this issue May 18, 2020 · 5 comments

Comments

@dsm5000
Copy link

dsm5000 commented May 18, 2020

when you have a link inside a paragraph it works fine in IOS and Android, but does not register a click on web. It woks fine when you put he link outside of a paragraph.

@thenexus00
Copy link

Since upgrading Flutter and to the latest version of this package I am actually finding that links inside paragraphs do not even work on my IOS app.

@ryan-berger
Copy link
Collaborator

ryan-berger commented Jun 7, 2020

@thenexus00 That is very concerning. I'll take a look on iOS, and see what I can find. Would you be able to provide an example that is broken so that I can reproduce it as well?

@dsm5000 This may be part of issue #300, could you describe to me what is going on? Is it crashing, or is it just not registering clicks?

@dsm5000
Copy link
Author

dsm5000 commented Jun 8, 2020

The click is not registered at all. What i have found is this:
<p>This will <a href='https://some.url'>Work</a> fine</a>
<p><a href='https://some.url'>this will not register a click in web</a></p>

@thenexus00
Copy link

@thenexus00 That is very concerning. I'll take a look on iOS, and see what I can find. Would you be able to provide an example that is broken so that I can reproduce it as well?

I got it sorted. What I found was it was to do with the IOS target and the newer IOS changes. In particular it was the safari web and url launcher specifically.
After a lot of googling and updating flutter it was a matter of updating the POD file with some extra code. Despite having the minimum version set in Xcode it was not fully working. Clearing out pod files, and updating other packages as well fixed the issue. Was not one specific fix, it was several.

@erickok
Copy link
Collaborator

erickok commented Feb 8, 2021

Seems there were several individual glitches wrt links not working, but all should be fixed, notably via #499 (not yet released, so use master if you must).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants