Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will the 1.0.0 version also include web support? #237

Closed
vazkir opened this issue Mar 3, 2020 · 7 comments
Closed

Will the 1.0.0 version also include web support? #237

vazkir opened this issue Mar 3, 2020 · 7 comments

Comments

@vazkir
Copy link

vazkir commented Mar 3, 2020

The issue
I am have tested the 1.0.0-pre1 version on web and each page using the plugin fails.

This are the logs I get returned every-time:
Another exception was thrown: Assertion failed: file:///Users/vascowerk/Development/flutter/packages/flutter/lib/src/rendering/box.dart:1694:12
Another exception was thrown: NoSuchMethodError: invalid member on null: 'scrollOffsetCorrection'
Another exception was thrown: NoSuchMethodError: invalid member on null: 'debugAssertIsValid'
Another exception was thrown: NoSuchMethodError: invalid member on null: 'visible'
Another exception was thrown: NoSuchMethodError: ''

Other info:

  • I am using the plugin in an application that show different articles with their corresponding HTML, so I tested this on different HTML layouts and they all returned the same errors.
  • The release version 0.11.1 does work with all the items the 1.0.0-pre1 version didn't work with, so on Flutter web.
  • The same items also work on native iOS (haven't tested Android yet).

Thanks in advance for any help!

@Sub6Resources
Copy link
Owner

Sub6Resources commented Mar 4, 2020

Interesting. Thank you for catching this regression. There is a chance that 1.0.0 will not support web right off because of its dependency on third-party plugins that may or may not support web. I plan on releasing a light-weight version of the plugin shortly that only has core functionality and should work on web right away.

@vazkir
Copy link
Author

vazkir commented Mar 5, 2020

Thanks for your response and I am looking out for that version so I can test it.

p.s. I do hope you won't stop supporting this plugin when webview_flutter hits their 1.0 release. I am building an app with your plugin that is faster than a WKWebView (iOS) or WebView (Android) in loading HTML. I know this because we have build about 6 similar Native iOS and Android apps with their native webview counterparts, and I have also tested webview_flutter and both had similar results.

@Sub6Resources
Copy link
Owner

Yeah, I've mentioned before that I plan on supporting this beyond the 1.0 release of webview_flutter. The README is a bit outdated and will be replaced soon. It seems I've found several use cases that a webview is just plain overkill for.

@jlcool
Copy link
Contributor

jlcool commented Apr 9, 2020

Didn't notice that he didn't support the web, so upgraded it, which made it unable to run on the web. I'm looking forward to supporting the web as soon as possible

@jlcool
Copy link
Contributor

jlcool commented Apr 9, 2020

Take a look at this. Deleting a third-party plug-in is not available flutter/flutter#42086

@Sub6Resources
Copy link
Owner

Good catch @jlcool. I'll look into what it will take to get this plugin to web.

@vazkir
Copy link
Author

vazkir commented Sep 1, 2020

This fix, made it work. So I am closing this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants