Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for embeded tweets #129

Closed
Kapranov98 opened this issue Jul 17, 2019 · 4 comments
Closed

Add support for embeded tweets #129

Kapranov98 opened this issue Jul 17, 2019 · 4 comments

Comments

@Kapranov98
Copy link

I propose to add support for displaying tweets via WebView. For resizing the WebView block you can use javascriptChannels.

<blockquote class="twitter-tweet"><p lang="en" dir="ltr">Woah, what’s this? A shiny new <a href="https://t.co/q4wnE46fGs">https://t.co/q4wnE46fGs</a> for desktop? Yup. IT’S HERE. <a href="https://t.co/8y4TMzqBGa">pic.twitter.com/8y4TMzqBGa</a></p>&mdash; Twitter (@Twitter) <a href="https://twitter.com/Twitter/status/1150812293124546561?ref_src=twsrc%5Etfw">July 15, 2019</a></blockquote> <script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>

@The-Redhat
Copy link
Contributor

I think this should be done through customRenderer when it's available. Otherwise the library loses its simplicity.

@Sub6Resources
Copy link
Owner

Yes, @The-Redhat is correct. Rendering tweets is outside of the scope of this package.

@Kapranov98
Copy link
Author

Will I be able to add a render of tweets in version 1.0 on my own? In the current version, we managed to implement it.

@Sub6Resources
Copy link
Owner

Yes, 1.0 will re-add support for customRender and will otherwise function similarly to the existing RichText parser, so while you may have to make some changes to account for some breaking changes in 1.0.0, you shouldn't have any problems implementing it using customRender.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants