Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: investigate timeouts in go test -race #1169

Open
charlieegan3 opened this issue Oct 3, 2024 · 0 comments
Open

test: investigate timeouts in go test -race #1169

charlieegan3 opened this issue Oct 3, 2024 · 0 comments

Comments

@charlieegan3
Copy link
Member

In #1146, a polling trigger for workspace diagnostics was added in order to stop an issue that occurred only when running the tests in the race detector.

The issue was observed such that a number of language server tests would intermittently run in such a way that events did not leave the cache in the expected state. This lead to timeouts where even after a long delay the results would be incorrect.

This issue was addressed by adding the WorkspaceDiagnosticsPoll option to the creation of new language servers which is only set when running with the race detector on. This is not ideal but eventing functionality is still tested in the regular tests with no poll interval.

This issue is for when there is more time to work out what could be causing this, and address the issue without needing polling in the race detector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant