Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a close button on the notify dialog? #3111

Closed
mjyu51 opened this issue Feb 16, 2020 · 4 comments
Closed

Add a close button on the notify dialog? #3111

mjyu51 opened this issue Feb 16, 2020 · 4 comments
Assignees

Comments

@mjyu51
Copy link

mjyu51 commented Feb 16, 2020

Can we add a close button like this: (so that we can close the notify dialog)

image

@mjyu51 mjyu51 changed the title can I add a close button on the notify? Add a close button on the notify dialog? Feb 16, 2020
@nao-pon
Copy link
Member

nao-pon commented Feb 18, 2020

@mjyu51 Sometimes we want to hide it. The notification dialog is shared by all notifications, so once you hide it, it will reappear if you get another notification. Do you like that feeling?

@mjyu51
Copy link
Author

mjyu51 commented Feb 19, 2020

@nao-pon, Thanks a lot for the response.

If we can make it an option for the user/developer, it will be much more powerful. I understood that notifications share the the dialog. I am wondering if it could be possible to add an option to the shared notifications dialog with this top-right cross button for closing all notifications and the dialog ( like a standard "window" with close button. Or in the code, we can do something like

ndialog.showCloseButton(true/false); // to turn the close button on and off

or
fm.notify({type:'copy', ...., showCloseButton: true/false}); //this might follow your suggestion?

This will be much more flexible.

Thanks,

@nao-pon
Copy link
Member

nao-pon commented Feb 21, 2020

@mjyu51 The display / non-display option of the close button is set in the notification dialog collectively (set at initialization). Also add a minimize button (always enabled). When minimized, it becomes a small icon with a percentage and a progress bar in one corner of the screen. Click the icon to return to its original size.

@mjyu51
Copy link
Author

mjyu51 commented Feb 21, 2020

@nao-pon, this is GREAT! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants