-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate images in avatars #2
Comments
I have the same issue on Linux |
Same on Windows 11 |
Same issue on MacOs 10.14.6 |
Even after several reinstall (Linux only), I can't reproduce this issue guys sorry 😕 |
I tried this plugin and saw it not working when installed via snap. |
I'm also experiencing this bug. Here are some screenshots and the HTML of an affected element, which may help diagnose the problem. <div data-item-id="t:v34Ff35NtNx3QnF5gHZXWB3yxXX1mX4pLJDS4iHJ"
style="touch-action: pan-x pan-y; position: absolute; top: 0px; width: 100%; height: 85px;">
<div class="swipe-backing" style="top: 0px; bottom: 0px; position: absolute;"></div>
<div style="transform: translate3d(0px, 0px, 0px);">
<div class="list-item list-tabular-item " style="height: 85px;">
<div class="list-column list-column-Item" style="flex: 1 1 0%;">
<div style="display: flex; align-items: flex-start;">
<div class="icons-column">
<div class="thread-icon thread-icon-none thread-icon-star-on-hover" title="Star"></div>
<div class="thread-injected-icons injected-region-visible"
style="flex-direction: column; position: relative; display: inline-flex; height: 100%;"><span
class="name"> role: ThreadListIcon (thread:<Thread>)</span>
<div class="thread-avatar"
style="display: inline-block; width: 32px; height: 32px; border-radius: 500px;"><img width="32"
height="32" src="http://logo.clearbit.com/InsideApple.Apple.com"
style="max-width: 100%; width: 32px; height: 32px; border-radius: 500px;"></div><span
style="clear: both;"></span>
</div>
</div>
<div class="thread-info-column">
<div class="participants-wrapper">
<div class="participants" dir="auto"><span></span><span class="unread-false">Apple</span></div><span
style="flex: 1 1 0%;"></span>
<div class="thread-injected-timestamp injected-region-visible"><span class="timestamp">Jun 24</span><span
class="name"> role: ThreadListTimestamp (thread:<Thread>, fallback:<Function>)</span><span
style="clear: both;"></span></div>
</div>
<div class="subject" dir="auto">Meet the new MacBook Pro 13”. Supercharged by M2.</div>
<div class="snippet-and-labels">
<div class="snippet" dir="auto">Do even more, even faster with the new MacBook Pro 13”. Available now. ‌ ‌
‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌
‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌
‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌ ‌
‌ ‌ ‌ ‌ ‌ ‌ ‌ </div>
<div style="flex: 1 1 0%;"></div>
<div class="thread-injected-mail-labels injected-region-visible"
style="flex-direction: row; position: relative; display: inline-flex; height: 100%;"><span class="name">
role: Thread:MailLabel (thread:<Thread>, messages:<undefined>)</span>
<div class="thread-avatar"
style="display: inline-block; width: 42px; height: 42px; border-radius: 500px;"><img width="42"
height="42" src="http://logo.clearbit.com/InsideApple.Apple.com"
style="max-width: 100%; width: 42px; height: 42px; border-radius: 500px;"></div><span
style="clear: both;"></span>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div> |
It appears to me that for each thread, there is first an incorrectly positioned, 32px avatar at: div.icons-column > div.thread-injected-icons.injected-region-visible > div.thread-avatar > img And then there's a second, correctly positioned, 42px avatar at: div.thread-info-column > div.snippet-and-labels > div.thread-injected-mail-labels.injected-region-visible > div.thread-avatar > img The two avatars have this different width and height specified in the attributes of the |
I'm guessing that for some of us, MailSpring is displaying both of these simultaneously: mailspring-avatars/src/main.js Lines 10 to 14 in 43f03af
(For some unknown reason.) |
Hi, the trouble appear when you make 3 panel view and make the inbox window narrower. Could you fix the issue, since it still persists? ): |
Issue finally resolved ! Sorry for the long wait 😬 New release added : https://github.com/Striffly/mailspring-avatars/releases/tag/1.3.0 |
I installed the mailspring-avatars plugin. It works, but displays two different images for each avatar. MacOS Monterey beta 3
Screenshot
The text was updated successfully, but these errors were encountered: