Skip to content

Commit fc73e43

Browse files
committed
use only strong params and private methods to use url params
1 parent 2b0915a commit fc73e43

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

app/controllers/followings_controller.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ class FollowingsController < ApplicationController
66
# POST /followings/user.json
77
def create
88
@following = Following.new
9-
@user = User.find(params[:id])
109
if @following.build_saving(@user, current_user)
1110
flash[:notice] = "Success following #{@user.username}"
1211
else

app/controllers/sessions_controller.rb

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
class SessionsController < ApplicationController
2+
before_action :set_user, only: %i[create]
3+
24
def new; end
35

46
def create
5-
user = User.find_by_username(params[:username])
6-
if user
7-
session[:user_id] = user.id
8-
session[:username] = user.username
7+
if @user
8+
session[:user_id] = @user.id
9+
session[:username] = @user.username
910
redirect_to root_url, notice: 'Logged in!'
1011
else
1112
flash.now[:alert] = 'Username invalid'
@@ -18,4 +19,13 @@ def destroy
1819
session[:username] = nil
1920
redirect_to root_url, notice: 'Logged out!'
2021
end
22+
23+
private
24+
25+
# Use callbacks to share common setup or constraints between actions.
26+
def set_user
27+
@user = User.find_by_username(params[:username])
28+
rescue ActiveRecord::RecordNotFound
29+
@user = nil
30+
end
2131
end

0 commit comments

Comments
 (0)