removed net:http requests that are too slow for checking if link is img and replace with javascript validation for it

Author: Stricks1

app/assets/javascripts/application.js

@@ -14,3 +14,15 @@
 //= require activestorage
 //= require turbolinks
 //= require_tree .
+
+function imgErrorPhoto(image) {
+  image.onerror = '';
+  image.src = 'https://raw.githubusercontent.com/Stricks1/cap-twitter/feature/app/assets/images/user_default.png';
+  return true;
+}
+
+function imgErrorCover(image) {
+  image.onerror = '';
+  image.src = 'https://raw.githubusercontent.com/Stricks1/cap-twitter/feature/app/assets/images/cover_default.jpg';
+  return true;
+}

app/helpers/application_helper.rb

@@ -1,7 +1,3 @@
-require 'resolv-replace'
-require 'net/http'
-require 'uri'
-
 module ApplicationHelper
   def header_bar
     cntnt = "<a href='/opinions'>"
@@ -52,27 +48,15 @@ def flash_info
   def current_profile(usr)
     usr = fill_user_images(usr)
     begin
-      image_tag(usr.photo, class: 'profile p-2', alt: usr.username)
+      image_tag(usr.photo, class: 'profile p-2', alt: usr.username, onerror: 'imgErrorPhoto(this);')
     rescue Sprockets::Rails::Helper::AssetNotFound
       image_tag('https://raw.githubusercontent.com/Stricks1/cap-twitter/feature/app/assets/images/user_default.png', class: 'profile p-2', alt: usr.username)
     end
   end
 
   def fill_user_images(usr)
-#    usr.photo = 'https://raw.githubusercontent.com/Stricks1/cap-twitter/feature/app/assets/images/user_default.png' if usr.photo.blank? || !image_exists?(usr.photo)
-#    usr.cover_image = 'https://raw.githubusercontent.com/Stricks1/cap-twitter/feature/app/assets/images/cover_default.jpg' if usr.cover_image.blank? || !image_exists?(usr.cover_image)
     usr.photo = 'https://raw.githubusercontent.com/Stricks1/cap-twitter/feature/app/assets/images/user_default.png' if usr.photo.blank?
     usr.cover_image = 'https://raw.githubusercontent.com/Stricks1/cap-twitter/feature/app/assets/images/cover_default.jpg' if usr.cover_image.blank?
     usr
   end
-
-#  def image_exists?(url)
-#    response = {}
-#    uri = URI(url)
-#    Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == 'https') do |http|
-#      request = Net::HTTP::Get.new uri
-#      response = http.request request # Net::HTTPResponse object
-#    end
-#    response.content_type.starts_with?('image')
-#  end
 end

app/helpers/opinions_helper.rb

@@ -11,13 +11,13 @@ def linked_unlinked_comment(opi)
     opi.user = fill_user_images(opi.user)
     if current_user
       begin
-        link_to image_tag(opi.user.photo, class: 'timeline-photo', alt: opi.user.username), user_path(opi.user)
+        link_to image_tag(opi.user.photo, class: 'timeline-photo', alt: opi.user.username, onerror: 'imgErrorPhoto(this);'), user_path(opi.user)
       rescue Sprockets::Rails::Helper::AssetNotFound
         link_to image_tag('https://raw.githubusercontent.com/Stricks1/cap-twitter/feature/app/assets/images/user_default.png', class: 'timeline-photo', alt: opi.user.username), user_path(opi.user)
       end
     else
       begin
-        image_tag(opi.user.photo, class: 'timeline-photo', alt: opi.user.username)
+        image_tag(opi.user.photo, class: 'timeline-photo', alt: opi.user.username, onerror: 'imgErrorPhoto(this);')
       rescue Sprockets::Rails::Helper::AssetNotFound
         image_tag('https://raw.githubusercontent.com/Stricks1/cap-twitter/feature/app/assets/images/user_default.png', class: 'timeline-photo', alt: opi.user.username)
       end
@@ -28,13 +28,13 @@ def linked_unlinked_who(usr)
     usr = fill_user_images(usr)
     if current_user
       begin
-        link_to image_tag(usr.photo, class: 'rounded-circle who-photo mx-2 align-self-center', alt: usr.username), user_path(usr), class: 'align-self-center'
+        link_to image_tag(usr.photo, class: 'rounded-circle who-photo mx-2 align-self-center', alt: usr.username, onerror: 'imgErrorPhoto(this);'), user_path(usr), class: 'align-self-center'
       rescue Sprockets::Rails::Helper::AssetNotFound
         link_to image_tag('https://raw.githubusercontent.com/Stricks1/cap-twitter/feature/app/assets/images/user_default.png', class: 'rounded-circle who-photo mx-2 align-self-center', alt: usr.username), user_path(usr), class: 'align-self-center'
       end
     else
       begin
-        image_tag(usr.photo, class: 'rounded-circle who-photo mx-2 align-self-center', alt: usr.username)
+        image_tag(usr.photo, class: 'rounded-circle who-photo mx-2 align-self-center', alt: usr.username, onerror: 'imgErrorPhoto(this);')
       rescue Sprockets::Rails::Helper::AssetNotFound
         image_tag('https://raw.githubusercontent.com/Stricks1/cap-twitter/feature/app/assets/images/user_default.png', class: 'rounded-circle who-photo mx-2 align-self-center', alt: usr.username)
       end

app/helpers/users_helper.rb

@@ -40,7 +40,7 @@ def user_copied_info(opi)
   def cover_photo(usr)
     usr = fill_user_images(usr)
     begin
-      image_tag(usr.cover_image, class: 'cover-img', alt: 'Cover_Image')
+      image_tag(usr.cover_image, class: 'cover-img', alt: 'Cover_Image', onerror: 'imgErrorCover(this);')
     rescue Sprockets::Rails::Helper::AssetNotFound
       image_tag('https://raw.githubusercontent.com/Stricks1/cap-twitter/feature/app/assets/images/cover_default.jpg', class: 'cover-img', alt: 'Cover_Image')
     end
@@ -49,7 +49,7 @@ def cover_photo(usr)
   def link_user_img(usr)
     usr = fill_user_images(usr)
     begin
-      link_to image_tag(usr.photo, class: 'rounded-circle who-photo mx-2 align-self-center', alt: usr.username), user_path(usr), class: 'align-self-center'
+      link_to image_tag(usr.photo, class: 'rounded-circle who-photo mx-2 align-self-center', alt: usr.username, onerror: 'imgErrorPhoto(this);'), user_path(usr), class: 'align-self-center'
     rescue Sprockets::Rails::Helper::AssetNotFound
       link_to image_tag('https://raw.githubusercontent.com/Stricks1/cap-twitter/feature/app/assets/images/user_default.png', class: 'rounded-circle who-photo mx-2 align-self-center', alt: usr.username), user_path(usr), class: 'align-self-center'
     end
@@ -58,7 +58,7 @@ def link_user_img(usr)
   def user_photo(opi)
     opi.user = fill_user_images(opi.user)
     begin
-      image_tag(opi.user.photo, class: 'timeline-photo', alt: 'User')
+      image_tag(opi.user.photo, class: 'timeline-photo', alt: 'User', onerror: 'imgErrorPhoto(this);')
     rescue Sprockets::Rails::Helper::AssetNotFound
       image_tag('https://raw.githubusercontent.com/Stricks1/cap-twitter/feature/app/assets/images/user_default.png', class: 'timeline-photo', alt: 'User')
     end
@@ -67,7 +67,7 @@ def user_photo(opi)
   def profile_photo(usr)
     usr = fill_user_images(usr)
     begin
-      image_tag(usr.photo, class: 'profile-right p-2', alt: usr.username)
+      image_tag(usr.photo, class: 'profile-right p-2', alt: usr.username, onerror: 'imgErrorPhoto(this);')
     rescue Sprockets::Rails::Helper::AssetNotFound
       image_tag('https://raw.githubusercontent.com/Stricks1/cap-twitter/feature/app/assets/images/user_default.png', class: 'profile-right p-2', alt: usr.username)
     end