Skip to content

Commit fe06133

Browse files
authored
Merge pull request KhronosGroup#35 from MarijnS95/android-drop-patcher
android-sdk: No longer install removed `patcher;v4`
2 parents dac9bb8 + a4f5eb5 commit fe06133

3 files changed

Lines changed: 10 additions & 5 deletions

File tree

build-all.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ set -e
1313
./build-one.sh openxr 20231010.1 "$@"
1414
./build-one.sh openxr-sdk 20230614 "$@"
1515
./build-one.sh openxr-pregenerated-sdk 20230822 "$@"
16-
./build-one.sh openxr-android 20230713 "$@"
16+
./build-one.sh openxr-android 20231206 "$@"
1717
)

build-one.sh

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,18 @@ REPO="khronosgroup/docker-images"
2727
docker build "$@" . -f "$DOCKERFILE.Dockerfile" \
2828
--build-arg "VERSION=$VERSION" \
2929
-t "$REPO:$DOCKERFILE" \
30-
-t "$REPO:$DOCKERFILE.$VERSION"
30+
-t "$REPO:$DOCKERFILE.$VERSION" \
31+
$EXTRA_DOCKER_ARGS
3132
if [ "$OP" == "push" ]; then
3233
docker push "$REPO:$DOCKERFILE"
3334
docker push "$REPO:$DOCKERFILE.$VERSION"
3435
fi
36+
37+
# Show how to refer to it.
38+
HASH=$(docker inspect --format='{{index .RepoDigests 0}}' "$REPO:$DOCKERFILE.$VERSION" | sed -E -n "s/.*(sha256:.*)/\1/p")
39+
echo
40+
echo "** To refer to this image precisely, use:"
41+
echo " $REPO:$DOCKERFILE.$VERSION@$HASH"
42+
3543
[ -n "$CI" ] && echo "::endgroup::"
3644
)

install-android-sdk.sh

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@ echo y | $SDKMANAGER "ndk;${ANDROID_NDK_VERSION}" >> /dev/null
4141
echo "Installing CMake ${ANDROID_CMAKE_VERSION}"
4242
echo y | $SDKMANAGER "cmake;${ANDROID_CMAKE_VERSION}" >> /dev/null
4343

44-
echo "Installing the Android 'patcher'"
45-
echo y | $SDKMANAGER "patcher;v4" >> /dev/null
46-
4744
echo "Installing the Android build tools ${ANDROID_BUILD_TOOLS}"
4845
echo y | $SDKMANAGER "build-tools;${ANDROID_BUILD_TOOLS}" >> /dev/null
4946

0 commit comments

Comments
 (0)