Feat: requet with more Http-Methods and reply types #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still working on it, but it's a bit more than expected at first. I'm creating this draft as some "sort of sign" that work is being done, just a bit slow. I have other stuff going on, so it's not for a lack of trying.
This currently seems to work, but I have not tested every Http-Method and every reply.
I also think it's kinda messy, even though I've tried to split this sensibly.
I've based
MultiRequestonGetRequest. I thought about replacing it, but I'm not sure if that's ok.If there are
Migrators for Plugin settings, I could add one (forPostRequestandGetRequest) , sinceMultiRequestis supposed to be to handle "all of that and more".Also unit tests would be nice, but that is itself a big task.
Input from anyone is welcome. However I intend to refactor a bunch to make it easier to read/understand, so smaller comments might be irrelevant later.
but in the end, this would then resolve #2