Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Deno package to work #921

Open
StoneCypher opened this issue Jun 24, 2022 · 1 comment
Open

Get Deno package to work #921

StoneCypher opened this issue Jun 24, 2022 · 1 comment

Comments

@StoneCypher
Copy link
Owner

StoneCypher commented Jun 24, 2022

Can't produce the TS package because Deno refuses to resolve Typescript filenames correctly

Can't produce the ES6 package because Deno refuses to resolve Node names correctly

> import * as jssm from "https://deno.land/x/jssm/es6/jssm.js"
Download https://deno.land/x/jssm/es6/jssm.js
Warning Implicitly using latest version (5.71.1) for https://deno.land/x/jssm/es6/jssm.js
Download https://deno.land/x/jssm@5.71.1/es6/jssm.js
Download https://deno.land/x/jssm@5.71.1/es6/jssm-dot
Download https://deno.land/x/jssm@5.71.1/es6/jssm_constants
Download https://deno.land/x/jssm@5.71.1/es6/jssm_error
Download https://deno.land/x/jssm@5.71.1/es6/jssm_util
Download https://deno.land/x/jssm@5.71.1/es6/version
Uncaught TypeError: Module not found "https://deno.land/x/jssm@5.71.1/es6/jssm_error".
    at https://deno.land/x/jssm@5.71.1/es6/jssm.js:7:27
    at async <anonymous>:2:14
>

Can't use a minified es6 or minified es5 CJS package because the Deno runtime is buggy and has a stack overflow attempting to load the module

> import * as jssm from "https://deno.land/x/jssm/jssm.es5.cjs.js"
Download https://deno.land/x/jssm/jssm.es5.cjs.js
Warning Implicitly using latest version (5.71.1) for https://deno.land/x/jssm/jssm.es5.cjs.js
Download https://deno.land/x/jssm@5.71.1/jssm.es5.cjs.js

thread 'main' has overflowed its stack

This includes after following the specialty CJS instructions.

Deno staff told me this wasn't fixable unless I rewrote my library to their standards, then used a codemod to support my existing users

Tried communicating with the Typescript staff and separately with the Deno staff about the fixes I think I see that are easy; was shut down in each case

It's not immediately clear to me how to fix this without writing a rollup plugin, and if I take that route, it inflates my install weight by another ~300k for basically no upside

Don't want to turn my back on the Deno community but not sure how to get help

blocks #1084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant