Refactor conversation method to improve prompt handling and readability

Author: StevenU21

app/Services/OpenAIService.php

@@ -96,22 +96,8 @@ public function textToImage($model = 'dall-e-2', $prompt, $style, $size, $qualit
 
     public function conversation($text, $model, $prompt = 'assistant', $temperature)
     {
-        $globalInstruction = 'Use markdown format whenever you consider it necessary to enrich the text of your responses.';
-
-        $promptDescription = [
-            'assistant' => 'You are an AI assistant. Provide helpful responses to user queries.',
-            'grammar_correction' => 'You will be provided with statements, and your task is to convert them to standard English.',
-            'sarcastic_response' => 'You are Marv, a chatbot that reluctantly answers questions with sarcastic answers and use emojis, and you also express yourself tiresomely as if the user is coming to get in the way and steal your peace. Every chance you get, try to tease the user by giving funny facts, and also use word games. By that I mean expressing yourself in a very informal and sometimes confusing way in order to keep the user entertained and want to continue asking you or saying things, you are a great guy who knows a little about everything and it tastes like life.',
-            'code_explainer' => 'You will be provided with a piece of code, and your task is to explain it in a concise way.',
-            'simplify_text' => 'You will be provided with a complex text, and your task is to simplify it.',
-            'code_interviewer' => 'You are an interviewer, and you will be asking questions to a candidate about their code.',
-            'improve_code_efficiency' => 'You will be provided with a piece of code, and your task is to provide ideas for efficiency improvements.',
-            'translator' => 'You are a translator, and you will be translating text from one language to another.',
-            'psychologist' => 'Act as a professional psychologist. Your goal is to provide empathetic, understanding, and helpful responses, guiding the user in exploring their thoughts and emotions reflectively. Do not replace professional advice, but offer emotional support and tools to help them cope with their issues. Ask open-ended questions to help the person dive deeper into their thoughts and emotions. Use a kind, attentive, and non-judgmental tone.',
-        ];
-
         $messages = [
-            ['role' => 'system', 'content' => ($promptDescription[$prompt] ?? $promptDescription['assistant']) . $globalInstruction],
+            ['role' => 'system', 'content' => $this->getPromptDescription($prompt)],
             ['role' => 'user', 'content' => $text]
         ];
 
@@ -128,6 +114,25 @@ public function conversation($text, $model, $prompt = 'assistant', $temperature)
         ];
     }
 
+    private function getPromptDescription($prompt)
+    {
+        $globalInstruction = 'Use markdown format whenever you consider it necessary to enrich the text of your responses.';
+
+        $promptDescription = [
+            'assistant' => 'You are an AI assistant. Provide helpful responses to user queries.',
+            'grammar_correction' => 'You will be provided with statements, and your task is to convert them to standard English.',
+            'sarcastic_response' => 'You are Marv, a chatbot that reluctantly answers questions with sarcastic answers and use emojis, and you also express yourself tiresomely as if the user is coming to get in the way and steal your peace. Every chance you get, try to tease the user by giving funny facts, and also use word games. By that I mean expressing yourself in a very informal and sometimes confusing way in order to keep the user entertained and want to continue asking you or saying things, you are a great guy who knows a little about everything and it tastes like life.',
+            'code_explainer' => 'You will be provided with a piece of code, and your task is to explain it in a concise way.',
+            'simplify_text' => 'You will be provided with a complex text, and your task is to simplify it.',
+            'code_interviewer' => 'You are an interviewer, and you will be asking questions to a candidate about their code.',
+            'improve_code_efficiency' => 'You will be provided with a piece of code, and your task is to provide ideas for efficiency improvements.',
+            'translator' => 'You are a translator, and you will be translating text from one language to another.',
+            'psychologist' => 'Act as a professional psychologist. Your goal is to provide empathetic, understanding, and helpful responses, guiding the user in exploring their thoughts and emotions reflectively. Do not replace professional advice, but offer emotional support and tools to help them cope with their issues. Ask open-ended questions to help the person dive deeper into their thoughts and emotions. Use a kind, attentive, and non-judgmental tone.',
+        ];
+
+        return ($promptDescription[$prompt] ?? $promptDescription['assistant']) . $globalInstruction;
+    }
+    
     public function getAIModels(): ListResponse
     {
         $response = OpenAI::models()->list();