Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EqualityComparerBase #18

Closed
2 tasks done
StephenCleary opened this issue Feb 3, 2019 · 0 comments
Closed
2 tasks done

Fix EqualityComparerBase #18

StephenCleary opened this issue Feb 3, 2019 · 0 comments
Assignees
@StephenCleary
Milestone
v5.0.6

Comments

@StephenCleary
Copy link
Owner

StephenCleary commented Feb 3, 2019 •
edited
Loading

Our current EqualityComparerBase implementation of System.Collections.IEqualityComparer.Equals has the possibility of stack overflow if applied to objects of unrelated types that both forward their object.Equals(object) implementations to a Nito.Comparer comparer.
@StephenCleary StephenCleary self-assigned this Feb 3, 2019
@StephenCleary StephenCleary added this to the v5.0.6 milestone Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephenCleary StephenCleary

Labels
None yet
Projects
None yet
Milestone
v5.0.6
Development

No branches or pull requests
1 participant
@StephenCleary