Rename 3 methods in URLManager

Author: albertodebortoli

Stellar/Sources/Core/Constants/Constants.swift

@@ -26,7 +26,7 @@ struct GitHubAPI {
     static let tokenFile = ".GITHUB-TOKEN"
 
     static var gitHubToken: String = {
-        let tokenFileURL = URLManager().systemLocation()
+        let tokenFileURL = URLManager().homeStellarLocation()
             .appendingPathComponent(GitHubAPI.tokenFile)
 
         guard FileManager.default.fileExists(at: tokenFileURL) else {

Stellar/Sources/Core/Installer/CLIInstaller.swift

@@ -94,7 +94,7 @@ public final class CLIInstaller: CLIInstallerProtocol {
             throw ReleaseProviderErrors.releaseNotAvailable(version)
         }
 
-        let installURL = try urlManager.systemVersionLocation(version)
+        let installURL = try urlManager.cliLocation(version)
 
         try fileManager.withTemporaryDirectory(
             path: nil,

Stellar/Sources/Core/Providers/Support/LocalVersion.swift

@@ -18,7 +18,7 @@ public struct LocalVersion: Comparable, CustomStringConvertible {
     ///
     /// - Parameter version: version to locate.
     init?(version: SemVer) throws {
-        let folderPath = try URLManager().systemVersionLocation(version.description).path
+        let folderPath = try URLManager().cliLocation(version.description).path
         var isDirectory = ObjCBool(false)
         guard FileManager.default.fileExists(atPath: folderPath, isDirectory: &isDirectory), isDirectory.boolValue else {
             return nil

Stellar/Sources/Core/Providers/VersionResolver.swift

@@ -77,7 +77,7 @@ public final class VersionResolver: VersionResolving {
     // MARK: - Public Functiosn
 
     public func installedVersions() throws -> [LocalVersion] {
-        try urlManager.systemVersionsLocation().glob("*").compactMap {
+        try urlManager.cliVersionsLocation().glob("*").compactMap {
             LocalVersion(path: $0)
         }.sorted()
     }
@@ -87,7 +87,7 @@ public final class VersionResolver: VersionResolving {
     }
 
     public func pathForVersion(_ version: String) throws -> URL? {
-        try urlManager.systemVersionLocation(version)
+        try urlManager.cliLocation(version)
     }
 
     public func isVersionInstalled(_ version: String) throws -> Bool {

Stellar/Sources/Core/URLManager/URLManager.swift

@@ -65,7 +65,7 @@ final class URLManager {
     ///
     /// - Parameter subfolder: optional subfolder.
     /// - Returns: full path.
-    func systemLocation(subfolder: String? = nil) -> URL {
+    func homeStellarLocation(subfolder: String? = nil) -> URL {
         let homeStellarURL = fileManager
             .homeDirectoryForCurrentUser
             .appendingPathComponent(FolderConstants.dotStellarFolder)
@@ -79,8 +79,8 @@ final class URLManager {
     /// Return the location to the installed versions.
     ///
     /// - Returns: a URL to the folder containing the installed versions
-    func systemVersionsLocation() throws -> URL {
-        let url = systemLocation(subfolder: FolderConstants.versionsFolder)
+    func cliVersionsLocation() throws -> URL {
+        let url = homeStellarLocation(subfolder: FolderConstants.versionsFolder)
         // not sure if we should create the folder
         if !fileManager.folderExists(at: url) {
             try fileManager.createFolder(at: url)
@@ -92,8 +92,8 @@ final class URLManager {
     ///
     /// - Parameter version: version to get.
     /// - Returns: a URL to the installed version
-    func systemVersionLocation(_ version: String) throws -> URL {
-        let url = systemLocation(subfolder: FolderConstants.versionsFolder)
+    func cliLocation(_ version: String) throws -> URL {
+        let url = homeStellarLocation(subfolder: FolderConstants.versionsFolder)
             .appendingPathComponent(version)
         // not sure if we should create the folder
         if !fileManager.folderExists(at: url) {