Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Java Script is disabled the only thing visible is the loader instead of basic text #92

Open
nathanbiller opened this issue Oct 12, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@nathanbiller
Copy link
Contributor

I'm not sure if it's possible to fail elegantly? I don't expect things to look good if javascript is disabled, but I would still like users to be able to access the content.

Screenshot 2019-10-11 20 06 17

@imawhale
Copy link

Displaying an error message such as:

"This site requires javascript..."

Would help.

@sk33lz
Copy link

sk33lz commented Feb 7, 2020

I figured out a much more accessible workaround for the preloader that I will submit a PR for at some point.

The theme adds a js class to the body tag when JavaScript is enabled, so add .js before the #preloader and #status ids in the _utils.scss file. Then update the corresponding Preloader jQuery selectors in the fresh.js file. This will ensure the styles for the preloader divs are only loaded when JavaScript is enabled, otherwise they stay set as display:none.

@nathanbiller
Copy link
Contributor Author

Awesome, @sk33lz !

@rgommers
Copy link

@sk33lz any chance you could get back to this, or even just post a diff of what worked for you here?

@sk33lz
Copy link

sk33lz commented Nov 25, 2020

I got sidetracked by a newborn this year on my personal sites! I will try to put together a PR before the new year with the relevant changes.

@StefMa StefMa added the bug Something isn't working label Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants