Only capture the absolute necessary values inside closures, to avoid improperly caching or reusing of core bluetooth objects #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…improperly caching or reusing of core bluetooth objects
klundberg
force-pushed
the
capture-only-needed-values
branch
from
4605c34
to
a705e94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, client code that, for instance, calls
monitorConnection(for:)(which returns a publisher that never completes) could erroneously keep the passed-inPeripheral(and the associatedCBPeripheral) in memory for much longer than desired, which could lead to issues of reusing the peripheral by the system if it is invalid to do so.