Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Install rf on ExchangeNode if its offsprings deny the rf and PlanNodes always adopts small rf #30949

Closed
wants to merge 1 commit into from
Closed

[Refactor] Install rf on ExchangeNode if its offsprings deny the rf and PlanNodes always adopts small rf #30949

wants to merge 1 commit into from

Conversation

satanson
Copy link
Contributor

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • [] Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

ZiheLiu
ZiheLiu previously approved these changes Sep 13, 2023
View reviewed changes
@satanson
Copy link
Contributor Author

@Mergifyio rebase main

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023

rebase main

✅ Branch has been successfully rebased

@satanson satanson force-pushed the rf_pushdown_opt branch 2 times, most recently from 588132c to 6a6c8d6 Compare September 14, 2023 15:57
@kangkaisen kangkaisen enabled auto-merge (squash) September 15, 2023 07:50
@satanson
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2023

rebase

✅ Branch has been successfully rebased

@satanson
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2023

rebase

✅ Branch has been successfully rebased

@satanson
Copy link
Contributor Author

@Mergifyio rebase

@satanson
[Refactor] Install rf on ExchangeNode if its offsprings deny the rf a…
0ce5b07 
…nd PlanNodes always adopts small rf

Signed-off-by: satanson <ranpanf@gmail.com>
@mergify
Copy link
Contributor

mergify bot commented Sep 20, 2023

rebase

✅ Branch has been successfully rebased

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE Incremental Coverage Report]

😍 pass : 5 / 5 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/planner/RuntimeFilterDescription.java 4 4 100.00% []
🔵 com/starrocks/planner/ExchangeNode.java 1 1 100.00% []

@wanpengfei-git
Copy link
Collaborator

[BE Incremental Coverage Report]

😍 pass : 0 / 0 (0%)

@satanson satanson closed this Oct 11, 2023
auto-merge was automatically disabled October 11, 2023 01:56

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangkaisen kangkaisen kangkaisen approved these changes

@ZiheLiu ZiheLiu ZiheLiu approved these changes

Assignees

@satanson satanson

Labels
behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@satanson @wanpengfei-git @kangkaisen @ZiheLiu