-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] add show processlist from xxx
command to show process list of specify frondend
#13326
base: main
Are you sure you want to change the base?
Conversation
show all processlist
command to show process list of …show processlist from all
command to show process list of …
…t of specify frondend
show processlist from all
command to show process list of …show processlist from xxx
command to show process list of specify frondend
48f38b7
to
8ad7c86
Compare
docs/sql-reference/sql-statements/Administration/SHOW PROCESSLIST.md
Outdated
Show resolved
Hide resolved
@@ -12,9 +12,10 @@ | |||
public class ShowProcesslistStmt extends ShowStmt { | |||
private static final ShowResultSetMetaData META_DATA = | |||
ShowResultSetMetaData.builder() | |||
.addColumn(new Column("FeHost", ScalarType.createVarchar(16))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a command from MySQL.
I think the output should be the same as MySQL's. Then other BIs or management tools can recognize the results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the META_DATA has already add two new column ConnectionStartTime and IsPending which different from mysql protocol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And, If no new column is added, it is impossible to determine which frondend the session belongs to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imay take a look? how to deal with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about put FeHost at the end of all columns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to name it AccessAddress?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Named FeHost will be more easier to understand?
.addColumn(new Column("Id", ScalarType.createType(PrimitiveType.BIGINT))) | ||
.addColumn(new Column("User", ScalarType.createVarchar(16))) | ||
.addColumn(new Column("Host", ScalarType.createVarchar(16))) | ||
.addColumn(new Column("ClientHost", ScalarType.createVarchar(16))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use Host to be compatible with MySQL output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will Keep current name "Host"
Kudos, SonarCloud Quality Gate passed! |
…all frontends
What type of PR is this:
Which issues of this PR fixes :
Fixes #13312
Problem Summary(Required) :
Checklist: