Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] build starrocks-thrift-sdk with docker #389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kyo-tom
Copy link

@kyo-tom kyo-tom commented Oct 12, 2024

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes #388

Problem Summary(Required) :

Build the starrocks-thrift-sdk module using docker.
Use the exec-maven-plugin and build-helper-maven-plugin plugins to automatically build and compile thrift during the Maven build. You no longer need to manually execute build-thrift.sh before the Maven build.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function

@kyo-tom kyo-tom force-pushed the build-thrift-with-docker branch 3 times, most recently from 135606b to 4644bf7 Compare October 12, 2024 07:08
@kyo-tom
Copy link
Author

kyo-tom commented Oct 12, 2024

PTAL @banmoy

Signed-off-by: kyotom <kyotom@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build the starrocks-thrift-sdk module using docker
1 participant