add secret to runner overridable parameters list #5744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add secret to the list of overridable parameters to avoid the error - attribute “secret” for the runner parameter “cmd” in action “core.local” cannot be overridden. Why is this required - We want to create action core.winrm_ps_cmd_secure which is same as core.winrm_ps_cmd where the input parameter cmd is hidden. We have a use case where we need to supply credentials inside the cmd section so it's not visible in stack storm UI after execution.
pull-request-size
bot
added
the
size/XS
|
|
|
I think this makes sense, but I would like to see something a little more intelligent for the Would you look at how we can prevent people from setting |
|
@cognifloyd sorry I do not know how to do this, can you elaborate or give me some guidance on how to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add secret to the list of overridable parameters to avoid the error - attribute “secret” for the runner parameter “cmd” in action “core.local” cannot be overridden.
Why is this required -
We want to create action core.winrm_ps_cmd_secure which is same as core.winrm_ps_cmd where the input parameter cmd is hidden. We have a use case where we need to supply credentials inside the cmd section so it's not visible in stack storm UI after execution.