fix: timediff typo

[blackstrip]

Problem:

When i use the webui to make some timediff critera comparison in rules, it always return the TypeError: '>' not supported between instances of 'float' and 'str'

Check:

I tried so many value in critera form, it's just not work.
Then i found in operators.py, the _timediff is returned (utc_now - diff_target_utc).total_seconds() as a float number, the timedelta.total_seconds() is always return float type, but the critera-comparison is str or int

Fix:

Just convert the critera value to float, it will be fine.

[arm4b]

@blackstrip Thanks for the contribution!

Could you please add the Changelog for this PR and, ideally some Unit test to cover the case.

Perhaps more details about how you caught this issue/error would help too for someone to review it.

[blackstrip]

@blackstrip Thanks for the contribution!

Could you please add the Changelog for this PR and, ideally some Unit test to cover the case.

Perhaps more details about how you caught this issue/error would help too for someone to review it.

Hi @armab , Thanks for the reply!
The PR is updated.

[amanda11]

@blackstrip Thanks for contribution, the latest merge seems to have removed your CHANGELOG changes, could you update to master and try again with the changelog?

[blackstrip]

@amanda11 Thanks for review, updated.

[amanda11]

@blackstrip One small comment on changelog, and I wonder did you look to see if it was possible to write a UT for the fix as per @armab's suggestion?

[blackstrip]

Updated. please check again. thx.

[arm4b]

Thanks for the fix! 👍

[arm4b]

@blackstrip Looks like the linting is failing https://github.com/StackStorm/st2/runs/4715712255?check_suite_focus=true#step:11:122
Can you please reformat the unit/test_operators.py with Black?

Additionally, new unit tests might need a bit more work per CI failures: https://github.com/StackStorm/st2/runs/4715712802

[blackstrip]

@blackstrip Looks like the linting is failing https://github.com/StackStorm/st2/runs/4715712255?check_suite_focus=true#step:11:122 Can you please reformat the unit/test_operators.py with Black?

Additionally, new unit tests might need a bit more work per CI failures: https://github.com/StackStorm/st2/runs/4715712802

Hi @armab , thx for review. the case is udpated, but maybe git-action failed? please can you re-check?

[arm4b]

That worked.
Merged, thanks!