-
-
Notifications
You must be signed in to change notification settings - Fork 758
limit memory and output #5320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
limit memory and output #5320
Conversation
Morad Faris seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Thanks for the contribution. The change overall seems reasonable (I will add in-line code comments later), but can you please provide some context and background on this change? |
@Moradf90 I just merged in Master. Would you please add a changelog entry and add a PR description? |
@cognifloyd changelog entry and description added. |
This looks like a useful functionality, but it think it would make more sense / be more useful if this value could also be provided / overridden on action basis - making it an python runner parameter. This way admin / pack author can specify limits on per action basis using immutable default parameter value. |
@Kami done :) |
@Moradf90 Could you sign the CLA please? |
I did |
@Moradf90 Yes, I see that you have signed the CLA. I suspect your otorio.com email is not associated with your github account. The CLA assistant uses the email on each commit to see who has signed the CLA. Could you do one of:
|
we use stackstorm as a base platform to execute plugin actions on our product.
the plugins (packs on st2) will be developed by anyone who will integrate with our product.
then we need to limit the execution to maximum memory size and maximum output result.
add two new configurations underperformance:
by default, they set to zero, which means unlimited.