Skip to content

Commit eba62dd

Browse files
authored
Update to pants 2.14 (final) (#5817)
* pants: silence un-actionable unowned dep warnings * bump to pants 2.14.0 * update changelog entry
1 parent ec2d399 commit eba62dd

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

CHANGELOG.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Added
1010
* Continue introducing `pants <https://www.pantsbuild.org/docs>`_ to improve DX (Developer Experience)
1111
working on StackStorm, improve our security posture, and improve CI reliability thanks in part
1212
to pants' use of PEX lockfiles. This is not a user-facing addition.
13-
#5778 #5789
13+
#5778 #5789 #5817
1414
Contributed by @cognifloyd
1515

1616

pants.toml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ enabled = false
66
repo_id = "de0dea7a-9f6a-4c6e-aa20-6ba5ad969b8a"
77

88
[GLOBAL]
9-
pants_version = "2.14.0rc3"
9+
pants_version = "2.14.0"
1010
backend_packages = [
1111
# python
1212
"pants.backend.python",
@@ -84,6 +84,16 @@ root_patterns = [
8484
"/st2common/benchmarks/micro",
8585
]
8686

87+
[python-infer]
88+
# https://www.pantsbuild.org/docs/reference-python-infer#unowned_dependency_behavior
89+
# The default changed from "ignore" to "warning" in pants 2.14.
90+
# Many of the new warnings however have been adressed via explicit deps,
91+
# so the warnings are not helpful. In pants 2.16, a "visibility" feature might help
92+
# us to disambiguate deps between files without those explicit BUILD dependencies,
93+
# and without adding "# pants: no-infer-dep" comments all over the codebase.
94+
# Revisit this in pants 2.16 to see if it is feasible to use the default "warning".
95+
unowned_dependency_behavior = "ignore"
96+
8797
[bandit]
8898
lockfile = "lockfiles/bandit.lock"
8999
version = "bandit==1.7.0"

0 commit comments

Comments
 (0)