-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if sqs sensor config None set to None #121
if sqs sensor config None set to None #121
Conversation
@amanda11 |
sean.elliott seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Any one want to give me the old review? @armab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - perhaps longer term the access_key_id shouldn't really be mandatory, so that you can actually omit those parameters rather than setting to "None".
Can you sign the CLA first though, before we approve?
I've signed it several times trying to get the PR to update. Nothing ever updates or shows I signed the CLA. |
Is it associated with the wrong email perhaps? It doesn't even think you are a github user? |
Ha, got it! I thought... |
good? |
Still failing on CLA Looking at the history of the commits, we need to get the author changed on the previous 2 commits to the same email you used on the update readme, and then it should pass. |
Got it! that was a learning experience LOL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for the contribution, and the fun with git!
Following the action method of setting the keys to
None
which allows AWS to assume the EC2 role vs failing with a key/secret of"None"
.fixes #120