Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if sqs sensor config None set to None #121

Merged
merged 4 commits into from
Jun 21, 2022
Merged

if sqs sensor config None set to None #121

merged 4 commits into from
Jun 21, 2022

Conversation

satellite-no
Copy link
Contributor

Following the action method of setting the keys to None which allows AWS to assume the EC2 role vs failing with a key/secret of "None".

fixes #120

@satellite-no
Copy link
Contributor Author

@amanda11
Could I get a review :)

@CLAassistant
Copy link

CLAassistant commented Jun 10, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


sean.elliott seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@satellite-no
Copy link
Contributor Author

satellite-no commented Jun 17, 2022

Any one want to give me the old review? @armab

Copy link
Contributor

@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - perhaps longer term the access_key_id shouldn't really be mandatory, so that you can actually omit those parameters rather than setting to "None".
Can you sign the CLA first though, before we approve?

@satellite-no
Copy link
Contributor Author

I've signed it several times trying to get the PR to update. Nothing ever updates or shows I signed the CLA.

@amanda11
Copy link
Contributor

sean.elliott seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Is it associated with the wrong email perhaps? It doesn't even think you are a github user?

@satellite-no
Copy link
Contributor Author

satellite-no commented Jun 20, 2022

Ha, got it! I thought...

@satellite-no
Copy link
Contributor Author

good?

@amanda11
Copy link
Contributor

good?

Still failing on CLA Looking at the history of the commits, we need to get the author changed on the previous 2 commits to the same email you used on the update readme, and then it should pass.

@satellite-no
Copy link
Contributor Author

Got it! that was a learning experience LOL.

Copy link
Contributor

@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the contribution, and the fun with git!

@amanda11 amanda11 merged commit cc8ff4f into StackStorm-Exchange:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQS Sensor with EC2 Role
3 participants