Skip to content

Commit fce2c0c

Browse files
committed
Fix CLIENT ID error during handshake (#2909)
* Fix CLIENT ID error during handshake * update release notes * tilde
1 parent 5ec1cbe commit fce2c0c

File tree

3 files changed

+5
-0
lines changed

3 files changed

+5
-0
lines changed

docs/ReleaseNotes.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ Current package versions:
1010

1111
- Add support for new `BITOP` operations in CE 8.2 ([#2900 by atakavci](https://github.com/StackExchange/StackExchange.Redis/pull/2900))
1212
- Package updates ([#2906 by mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/2906))
13+
- Fix handshake error with `CLIENT ID` ([#2909 by mgravell](https://github.com/StackExchange/StackExchange.Redis/pull/2909))
1314

1415
## 2.8.41
1516

src/StackExchange.Redis/ResultProcessor.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -831,6 +831,9 @@ protected override bool SetResultCore(PhysicalConnection connection, Message mes
831831
{
832832
connection.ConnectionId = clientId;
833833
Log?.LogInformation($"{Format.ToString(server)}: Auto-configured (CLIENT) connection-id: {clientId}");
834+
835+
SetResult(message, true);
836+
return true;
834837
}
835838
}
836839
break;

tests/StackExchange.Redis.Tests/ConfigTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -472,6 +472,7 @@ public void GetClients()
472472
if (server.Features.ClientId)
473473
{
474474
var id = conn.GetConnectionId(server.EndPoint, ConnectionType.Interactive);
475+
Log("client id: " + id);
475476
Assert.NotNull(id);
476477
Assert.True(clients.Any(x => x.Id == id), "expected: " + id);
477478
id = conn.GetConnectionId(server.EndPoint, ConnectionType.Subscription);

0 commit comments

Comments
 (0)