Skip to content

Commit 265cc12

Browse files
authored
Make private & internal stuff sealed (#2915)
1 parent c364806 commit 265cc12

File tree

12 files changed

+38
-38
lines changed

12 files changed

+38
-38
lines changed

src/StackExchange.Redis/APITypes/GeoSearchShape.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,12 @@ public GeoSearchCircle(double radius, GeoUnit unit = GeoUnit.Meters) : base(unit
4646
_radius = radius;
4747
}
4848

49-
internal override int ArgCount => 3;
49+
internal sealed override int ArgCount => 3;
5050

5151
/// <summary>
5252
/// Gets the <see cref="RedisValue"/>s for this shape.
5353
/// </summary>
54-
internal override void AddArgs(List<RedisValue> args)
54+
internal sealed override void AddArgs(List<RedisValue> args)
5555
{
5656
args.Add(RedisLiterals.BYRADIUS);
5757
args.Add(_radius);
@@ -80,9 +80,9 @@ public GeoSearchBox(double height, double width, GeoUnit unit = GeoUnit.Meters)
8080
_width = width;
8181
}
8282

83-
internal override int ArgCount => 4;
83+
internal sealed override int ArgCount => 4;
8484

85-
internal override void AddArgs(List<RedisValue> args)
85+
internal sealed override void AddArgs(List<RedisValue> args)
8686
{
8787
args.Add(RedisLiterals.BYBOX);
8888
args.Add(_width);

src/StackExchange.Redis/ClientInfo.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ private static void AddFlag(ref ClientFlags value, string raw, ClientFlags toAdd
287287
if (raw.IndexOf(token) >= 0) value |= toAdd;
288288
}
289289

290-
private class ClientInfoProcessor : ResultProcessor<ClientInfo[]>
290+
private sealed class ClientInfoProcessor : ResultProcessor<ClientInfo[]>
291291
{
292292
protected override bool SetResultCore(PhysicalConnection connection, Message message, in RawResult result)
293293
{

src/StackExchange.Redis/CommandTrace.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ internal CommandTrace(long uniqueId, long time, long duration, RedisValue[] argu
6969
return BaseUrl + encoded0;
7070
}
7171

72-
private class CommandTraceProcessor : ResultProcessor<CommandTrace[]>
72+
private sealed class CommandTraceProcessor : ResultProcessor<CommandTrace[]>
7373
{
7474
protected override bool SetResultCore(PhysicalConnection connection, Message message, in RawResult result)
7575
{

src/StackExchange.Redis/Condition.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ protected override bool SetResultCore(PhysicalConnection connection, Message mes
384384
return false;
385385
}
386386

387-
private class ConditionMessage : Message.CommandKeyBase
387+
private sealed class ConditionMessage : Message.CommandKeyBase
388388
{
389389
public readonly Condition Condition;
390390
private readonly RedisValue value;
@@ -425,7 +425,7 @@ protected override void WriteImpl(PhysicalConnection physical)
425425
}
426426
}
427427

428-
internal class ExistsCondition : Condition
428+
internal sealed class ExistsCondition : Condition
429429
{
430430
private readonly bool expectedResult;
431431
private readonly RedisValue expectedValue;
@@ -501,7 +501,7 @@ internal override bool TryValidate(in RawResult result, out bool value)
501501
}
502502
}
503503

504-
internal class EqualsCondition : Condition
504+
internal sealed class EqualsCondition : Condition
505505
{
506506
internal override Condition MapKeys(Func<RedisKey, RedisKey> map) =>
507507
new EqualsCondition(map(key), type, memberName, expectedEqual, expectedValue);
@@ -535,7 +535,7 @@ public override string ToString() =>
535535

536536
internal override void CheckCommands(CommandMap commandMap) => commandMap.AssertAvailable(cmd);
537537

538-
internal sealed override IEnumerable<Message> CreateMessages(int db, IResultBox? resultBox)
538+
internal override IEnumerable<Message> CreateMessages(int db, IResultBox? resultBox)
539539
{
540540
yield return Message.Create(db, CommandFlags.None, RedisCommand.WATCH, key);
541541

@@ -580,7 +580,7 @@ internal override bool TryValidate(in RawResult result, out bool value)
580580
}
581581
}
582582

583-
internal class ListCondition : Condition
583+
internal sealed class ListCondition : Condition
584584
{
585585
internal override Condition MapKeys(Func<RedisKey, RedisKey> map) =>
586586
new ListCondition(map(key), index, expectedResult, expectedValue);
@@ -606,7 +606,7 @@ public override string ToString() =>
606606

607607
internal override void CheckCommands(CommandMap commandMap) => commandMap.AssertAvailable(RedisCommand.LINDEX);
608608

609-
internal sealed override IEnumerable<Message> CreateMessages(int db, IResultBox? resultBox)
609+
internal override IEnumerable<Message> CreateMessages(int db, IResultBox? resultBox)
610610
{
611611
yield return Message.Create(db, CommandFlags.None, RedisCommand.WATCH, key);
612612

@@ -643,7 +643,7 @@ internal override bool TryValidate(in RawResult result, out bool value)
643643
}
644644
}
645645

646-
internal class LengthCondition : Condition
646+
internal sealed class LengthCondition : Condition
647647
{
648648
internal override Condition MapKeys(Func<RedisKey, RedisKey> map) =>
649649
new LengthCondition(map(key), type, compareToResult, expectedLength);
@@ -679,7 +679,7 @@ public LengthCondition(in RedisKey key, RedisType type, int compareToResult, lon
679679

680680
internal override void CheckCommands(CommandMap commandMap) => commandMap.AssertAvailable(cmd);
681681

682-
internal sealed override IEnumerable<Message> CreateMessages(int db, IResultBox? resultBox)
682+
internal override IEnumerable<Message> CreateMessages(int db, IResultBox? resultBox)
683683
{
684684
yield return Message.Create(db, CommandFlags.None, RedisCommand.WATCH, key);
685685

@@ -708,7 +708,7 @@ internal override bool TryValidate(in RawResult result, out bool value)
708708
}
709709
}
710710

711-
internal class SortedSetRangeLengthCondition : Condition
711+
internal sealed class SortedSetRangeLengthCondition : Condition
712712
{
713713
internal override Condition MapKeys(Func<RedisKey, RedisKey> map) =>
714714
new SortedSetRangeLengthCondition(map(key), min, max, compareToResult, expectedLength);
@@ -736,7 +736,7 @@ public override string ToString() =>
736736

737737
internal override void CheckCommands(CommandMap commandMap) => commandMap.AssertAvailable(RedisCommand.ZCOUNT);
738738

739-
internal sealed override IEnumerable<Message> CreateMessages(int db, IResultBox? resultBox)
739+
internal override IEnumerable<Message> CreateMessages(int db, IResultBox? resultBox)
740740
{
741741
yield return Message.Create(db, CommandFlags.None, RedisCommand.WATCH, key);
742742

@@ -765,7 +765,7 @@ internal override bool TryValidate(in RawResult result, out bool value)
765765
}
766766
}
767767

768-
internal class SortedSetScoreCondition : Condition
768+
internal sealed class SortedSetScoreCondition : Condition
769769
{
770770
internal override Condition MapKeys(Func<RedisKey, RedisKey> map) =>
771771
new SortedSetScoreCondition(map(key), sortedSetScore, expectedEqual, expectedValue);
@@ -792,7 +792,7 @@ public override string ToString() =>
792792

793793
internal override void CheckCommands(CommandMap commandMap) => commandMap.AssertAvailable(RedisCommand.ZCOUNT);
794794

795-
internal sealed override IEnumerable<Message> CreateMessages(int db, IResultBox? resultBox)
795+
internal override IEnumerable<Message> CreateMessages(int db, IResultBox? resultBox)
796796
{
797797
yield return Message.Create(db, CommandFlags.None, RedisCommand.WATCH, key);
798798

src/StackExchange.Redis/Configuration/LoggingTunnel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ public static void LogToDirectory(ConfigurationOptions options, string path)
277277
options.Tunnel = tunnel;
278278
}
279279

280-
private class DirectoryLoggingTunnel : LoggingTunnel
280+
private sealed class DirectoryLoggingTunnel : LoggingTunnel
281281
{
282282
private readonly string path;
283283
private int _nextIndex = -1;

src/StackExchange.Redis/CursorEnumerable.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ public void Reset()
344344
internal static CursorEnumerable<T> From(RedisBase redis, ServerEndPoint? server, Task<T[]> pending, int pageOffset)
345345
=> new SingleBlockEnumerable(redis, server, pending, pageOffset);
346346

347-
private class SingleBlockEnumerable : CursorEnumerable<T>
347+
private sealed class SingleBlockEnumerable : CursorEnumerable<T>
348348
{
349349
private readonly Task<T[]> _pending;
350350
public SingleBlockEnumerable(RedisBase redis, ServerEndPoint? server, Task<T[]> pending, int pageOffset)

src/StackExchange.Redis/Message.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1627,7 +1627,7 @@ protected override void WriteImpl(PhysicalConnection physical)
16271627
public override int ArgCount => 0;
16281628
}
16291629

1630-
private class CommandSlotValuesMessage : Message
1630+
private sealed class CommandSlotValuesMessage : Message
16311631
{
16321632
private readonly int slot;
16331633
private readonly RedisValue[] values;

src/StackExchange.Redis/RedisBatch.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
namespace StackExchange.Redis
66
{
7-
internal class RedisBatch : RedisDatabase, IBatch
7+
internal sealed class RedisBatch : RedisDatabase, IBatch
88
{
99
private List<Message>? pending;
1010

src/StackExchange.Redis/RedisDatabase.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4934,7 +4934,7 @@ public Task<long> SortedSetRemoveRangeByValueAsync(RedisKey key, RedisValue min,
49344934
return ExecuteAsync(msg, ResultProcessor.Int64);
49354935
}
49364936

4937-
internal class ScanEnumerable<T> : CursorEnumerable<T>
4937+
internal sealed class ScanEnumerable<T> : CursorEnumerable<T>
49384938
{
49394939
private readonly RedisKey key;
49404940
private readonly RedisValue pattern;
@@ -5327,7 +5327,7 @@ private SortedSetScanResultProcessor() { }
53275327
=> SortedSetWithScores.TryParse(result, out SortedSetEntry[]? pairs, true, out count) ? pairs : null;
53285328
}
53295329

5330-
private class StringGetWithExpiryMessage : Message.CommandKeyBase, IMultiMessage
5330+
private sealed class StringGetWithExpiryMessage : Message.CommandKeyBase, IMultiMessage
53315331
{
53325332
private readonly RedisCommand ttlCommand;
53335333
private IResultBox<TimeSpan?>? box;
@@ -5371,7 +5371,7 @@ protected override void WriteImpl(PhysicalConnection physical)
53715371
public override int ArgCount => 1;
53725372
}
53735373

5374-
private class StringGetWithExpiryProcessor : ResultProcessor<RedisValueWithExpiry>
5374+
private sealed class StringGetWithExpiryProcessor : ResultProcessor<RedisValueWithExpiry>
53755375
{
53765376
public static readonly ResultProcessor<RedisValueWithExpiry> Default = new StringGetWithExpiryProcessor();
53775377
private StringGetWithExpiryProcessor() { }

src/StackExchange.Redis/RedisServer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -889,7 +889,7 @@ private protected override Message CreateMessage(in RedisValue cursor)
889889
private protected override ResultProcessor<ScanResult> Processor => processor;
890890

891891
public static readonly ResultProcessor<ScanResult> processor = new ScanResultProcessor();
892-
private class ScanResultProcessor : ResultProcessor<ScanResult>
892+
private sealed class ScanResultProcessor : ResultProcessor<ScanResult>
893893
{
894894
protected override bool SetResultCore(PhysicalConnection connection, Message message, in RawResult result)
895895
{

0 commit comments

Comments
 (0)