Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre release 1.0 #59

Merged
merged 12 commits into from
Jul 26, 2023
Merged

Pre release 1.0 #59

merged 12 commits into from
Jul 26, 2023

Conversation

benjaminaubin
Copy link
Contributor

@benjaminaubin benjaminaubin self-assigned this Jul 25, 2023
@benjaminaubin benjaminaubin requested a review from palp July 25, 2023 13:16
@benjaminaubin benjaminaubin marked this pull request as draft July 25, 2023 13:16
@benjaminaubin benjaminaubin requested a review from rromb July 25, 2023 13:33
@rromb rromb requested review from timudk and ablattmann July 25, 2023 13:44
@akx
Copy link
Contributor

akx commented Jul 25, 2023

The LPIPS vendoring isn't necessary if #50 is merged.

akx
akx reviewed Jul 25, 2023
View reviewed changes
sgm/__init__.py Show resolved Hide resolved
ablattmann
ablattmann suggested changes Jul 25, 2023
View reviewed changes
sgm/modules/autoencoding/losses/__init__.py Outdated Show resolved Hide resolved
requirements/pt13.txt Outdated Show resolved Hide resolved
requirements/pt2.txt Outdated Show resolved Hide resolved
@benjaminaubin
Copy link
Contributor Author

benjaminaubin commented Jul 25, 2023 •
edited
Loading

The LPIPS vendoring isn't necessary if #50 is merged.

Yes but we decided internally to not merge #50 for the future release
This LPIPS refactoring would have been necessary at some point in any case

akx
akx reviewed Jul 25, 2023
View reviewed changes
sgm/modules/autoencoding/lpips/vqperceptual.py Outdated Show resolved Hide resolved
sgm/modules/autoencoding/lpips/model/model.py Show resolved Hide resolved
sgm/__init__.py Show resolved Hide resolved
@akx akx mentioned this pull request Jul 25, 2023
Open
@benjaminaubin benjaminaubin changed the title Pre release 1.0 Pre release Jul 25, 2023
@akx akx mentioned this pull request Jul 25, 2023
Draft
palp
palp previously approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@palp palp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've merged this with #57 on my fork here and confirmed the tests pass & upstream dependencies are working, so this looks good from my perspective.

@benjaminaubin benjaminaubin requested review from timudk and removed request for timudk and rromb July 25, 2023 16:41
ablattmann
ablattmann previously approved these changes Jul 25, 2023
View reviewed changes
@benjaminaubin benjaminaubin marked this pull request as ready for review July 26, 2023 08:31
@benjaminaubin benjaminaubin changed the title Pre release Pre release 1.0 Jul 26, 2023
@benjaminaubin benjaminaubin requested review from palp and removed request for timudk July 26, 2023 08:39
palp
palp approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@palp palp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, passes tests on #57

@benjaminaubin benjaminaubin merged commit e596332 into main Jul 26, 2023
@benjaminaubin benjaminaubin deleted the pre-release-1.0 branch July 27, 2023 10:54
LinearFalcon pushed a commit to LinearFalcon/generative-models that referenced this pull request Jul 6, 2024
@benjaminaubin @LinearFalcon
Pre release changes for production (Stability-AI#59)
2b03704 
* clean requirements

* rm taming deps

* isort, black

* mv lipips, license

* clean vq, fix path

* fix loss path, gitignore

* tested requirements pt13

* fix numpy req for python3.8, add tests

* fix name

* fix dep scipy 3.8 pt2

* add black test formatter
SevanBrodjian pushed a commit to SevanBrodjian/sd-latent-exploration that referenced this pull request Aug 12, 2024
@benjaminaubin
Pre release changes for production (Stability-AI#59)
ac60da8 
* clean requirements

* rm taming deps

* isort, black

* mv lipips, license

* clean vq, fix path

* fix loss path, gitignore

* tested requirements pt13

* fix numpy req for python3.8, add tests

* fix name

* fix dep scipy 3.8 pt2

* add black test formatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akx akx akx left review comments

@palp palp palp approved these changes

@ablattmann ablattmann ablattmann left review comments

Assignees

@benjaminaubin benjaminaubin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benjaminaubin @akx @palp @ablattmann