Skip to content

Commit 423a337

Browse files
author
Dave Syer
committed
Move Visit to owner package (it's aggregate root)
1 parent 58fe629 commit 423a337

File tree

5 files changed

+4
-7
lines changed

5 files changed

+4
-7
lines changed

src/main/java/org/springframework/samples/petclinic/owner/Pet.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232

3333
import org.springframework.format.annotation.DateTimeFormat;
3434
import org.springframework.samples.petclinic.model.NamedEntity;
35-
import org.springframework.samples.petclinic.visit.Visit;
3635

3736
/**
3837
* Simple business object representing a pet.

src/main/java/org/springframework/samples/petclinic/owner/Visit.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
package org.springframework.samples.petclinic.visit;
16+
package org.springframework.samples.petclinic.owner;
1717

1818
import java.time.LocalDate;
1919

src/main/java/org/springframework/samples/petclinic/owner/VisitController.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
import javax.validation.Valid;
2121

22-
import org.springframework.samples.petclinic.visit.Visit;
2322
import org.springframework.stereotype.Controller;
2423
import org.springframework.validation.BindingResult;
2524
import org.springframework.web.bind.WebDataBinder;
@@ -63,6 +62,7 @@ public Visit loadPetWithVisit(@PathVariable("ownerId") int ownerId, @PathVariabl
6362
Owner owner = this.owners.findById(ownerId);
6463
Pet pet = owner.getPet(petId);
6564
model.put("pet", pet);
65+
model.put("owner", owner);
6666
Visit visit = new Visit();
6767
pet.addVisit(visit);
6868
return visit;
@@ -78,12 +78,11 @@ public String initNewVisitForm(@PathVariable("petId") int petId, Map<String, Obj
7878
// Spring MVC calls method loadPetWithVisit(...) before processNewVisitForm is
7979
// called
8080
@PostMapping("/owners/{ownerId}/pets/{petId}/visits/new")
81-
public String processNewVisitForm(@PathVariable("ownerId") int ownerId, @Valid Visit visit, BindingResult result) {
81+
public String processNewVisitForm(@ModelAttribute Owner owner, @Valid Visit visit, BindingResult result) {
8282
if (result.hasErrors()) {
8383
return "pets/createOrUpdateVisitForm";
8484
}
8585
else {
86-
Owner owner = this.owners.findById(ownerId);
8786
owner.getPet(visit.getPetId()).addVisit(visit);
8887
this.owners.save(owner);
8988
return "redirect:/owners/{ownerId}";

src/test/java/org/springframework/samples/petclinic/owner/OwnerControllerTests.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
import org.springframework.data.domain.Page;
4747
import org.springframework.data.domain.PageImpl;
4848
import org.springframework.data.domain.Pageable;
49-
import org.springframework.samples.petclinic.visit.Visit;
5049
import org.springframework.test.web.servlet.MockMvc;
5150

5251
/**

src/test/java/org/springframework/samples/petclinic/service/ClinicServiceTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@
3333
import org.springframework.samples.petclinic.owner.OwnerRepository;
3434
import org.springframework.samples.petclinic.owner.Pet;
3535
import org.springframework.samples.petclinic.owner.PetType;
36+
import org.springframework.samples.petclinic.owner.Visit;
3637
import org.springframework.samples.petclinic.vet.Vet;
3738
import org.springframework.samples.petclinic.vet.VetRepository;
38-
import org.springframework.samples.petclinic.visit.Visit;
3939
import org.springframework.stereotype.Service;
4040
import org.springframework.transaction.annotation.Transactional;
4141

0 commit comments

Comments
 (0)