Skip to content

Display the mixin config name in LVT errors. #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shedaniel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Display the mixin config name in LVT errors. #435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/org/spongepowered/asm/mixin/injection/callback/CallbackInjector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,8 +534,9 @@ private String generateBadLVTMessage(final Callback callback) {
if (expected.equals(found)) {
return String.format("Invalid descriptor on %s! Expected %s but found %s", this.info, callback.getDescriptor(), this.methodNode.desc);
}
return String.format("LVT in %s has incompatible changes at opcode %d in callback %s.\nExpected: %s\n Found: %s",
callback.target, position, this, expected, found);
String mixinConfigName = this.info.getContext().getMixin().getConfig().getName();
return String.format("LVT in %s has incompatible changes at opcode %d in callback %s provided by '%s'.\nExpected: %s\n Found: %s",
callback.target, position, this, mixinConfigName, expected, found);
}

/**
Expand Down