Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Inject not remapping properly. #448

Closed
SelfMadeSystem opened this issue Nov 11, 2020 · 2 comments
Closed

@Inject not remapping properly. #448

SelfMadeSystem opened this issue Nov 11, 2020 · 2 comments
Labels

Comments

@SelfMadeSystem
Copy link

I don't know if I'm doing anything wrong, but @Inject isn't remapping properly, so I have to remap it myself. For example, I have to do:

@Inject(method = "func_71384_a", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/Minecraft;func_71361_d(Ljava/lang/String;)V", ordinal = 2, shift = At.Shift.AFTER))

instead of

@Inject(method = "init", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/Minecraft;checkGLError(Ljava/lang/String;)V", ordinal = 2, shift = At.Shift.AFTER))
@SelfMadeSystem
Copy link
Author

Might be dup. of #414 but it seems that it's not just @at(target), but also @Inject(method)

@Mumfrey
Copy link
Member

Mumfrey commented Nov 17, 2020

If something this fundamental was broken I'd know about it by now. So I assume this is an incorrectly configured build. Please follow up in discord as this issue tracker is for bugs rather than support.

Edit: Also tagging an issue with [bug] doesn't turn your issue into a bug, please avoid adding "meta" to your issue descriptions, that's what labels are for

@Mumfrey Mumfrey closed this as completed Nov 17, 2020
@Mumfrey Mumfrey changed the title [Bug] @Inject not remapping properly. @Inject not remapping properly. Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants