Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev environment and mixin tweaker + mod in one jar doesn't work in yet another case #319

Open
Barteks2x opened this issue Apr 21, 2019 · 5 comments

Comments

@Barteks2x
Copy link

Issue looks similar to #207.

This time, when a mod that has a mixin, coremod and a normal forge mod in one jar is added as a standard compile or runtime dependency, mod mod won't get loaded. The same jar file is loaded when added as deobfCompile dependency, but what I want is a runtime dependency, not compile.

MANIFEST.MF contains:

Manifest-Version: 1.0
TweakOrder: 0
FMLCorePluginContainsFMLMod: true
FMLAT: cubicchunks_at.cfg
TweakClass: org.spongepowered.asm.launch.MixinTweaker
ForceLoadAsMod: true
FMLCorePlugin: io.github.opencubicchunks.cubicchunks.core.asm.coremod.
 CubicChunksCoreMod
@Mumfrey
Copy link
Member

Mumfrey commented Apr 24, 2019

Most likely a fault in the convoluted injection logic of FML agent again, too hacky for its own good. I'll look into it when I have a moment.

@TerminatorNL
Copy link

I too ran into this problem, but you can use deobfProvided as quick workaround. if you do that, you'll lose comments when browsing through your code, and it messes with the variable names.

But at runtime: it works like a charm.

@Barteks2x
Copy link
Author

deobfProvided is the exact opposite of what I need. Provided dependencies are used at compile time but not added to class path at runtime. I want something is on the classpath at runtime but that I don't have access to when compiling. It's way too easy to accidentally use some implementation detail from the implementation jar.

@TerminatorNL
Copy link

If you don't need it in your IDE... Can't you just add the jars to the mods/library folder? I might be missing your point here though.

@Barteks2x
Copy link
Author

The point is that it should just work without messing around in IDE settings every single time I refresh gradle project. ForgeGradle also has runClient and runServer tasks that won't really work without adding a runtime dependency there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants