Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpwa as key doesn't work #23

Closed
tacman opened this issue Jan 10, 2024 · 2 comments · Fixed by #27
Closed

phpwa as key doesn't work #23

tacman opened this issue Jan 10, 2024 · 2 comments · Fixed by #27

Comments

@tacman
Copy link
Contributor

tacman commented Jan 10, 2024

Version(s) affected

1.0

Description

Following the README instructions, using phpwa as the config key didn't work, but usa pwa (the alias) did.

How to reproduce

# config/packages/phpwa.yaml
phpwa:
    name: 'My App'

Possible Solution

# config/packages/phpwa.yaml
pwa:
    name: 'My App'

Additional Context

No response
@Spomky
Copy link
Member

Spomky commented Jan 10, 2024

😅

@Spomky Spomky linked a pull request Jan 10, 2024 that will close this issue
Documentation updated #27
Merged
4 tasks
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Documentation updated Spomky-Labs/pwa-bundle
2 participants
@tacman @Spomky